Repository navigation
JIT: Preserve inlining of profiled memcmp fallback - #135373
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6a688f5c-c26c-447f-b932-75363c0d4e11
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
@EgorBot -linux_amd -linux_intel --filter 'System.Text.RegularExpressions.Tests.Perf_Regex_Industry_SliceSlice*' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve inlining of the variable-length fallback when specializing profiled
SequenceEqualcalls. Clearing the original call's inline-candidate information before cloning also prevented fallback inlining, introducing helper calls and vector-register spills when the size guess missed.Keep the fallback's candidate information and return placeholder, and expand the QMARK before inlining. The fixed-size fast path remains eligible for unrolling.
On Windows x64, SliceSlice improves from 296.3 ms to 276.5 ms (pre-PR baseline: 281.9 ms). A reduced
Span.IndexOfrepro that trains with a seven-character needle, then searches with a four-character needle improves from 942 ns to 524 ns (baseline: 528 ns).Fixes #134865.