Skip to content

Allow PublishReadyToRunEmitSymbols to be overridden - #121406

Merged
kotlarmilos merged 4 commits into
dotnet:mainfrom
kotlarmilos:improvement/r2r-emit-symbols-prop
Nov 20, 2025
Merged

kotlarmilos merged 4 commits into
dotnet:mainfrom
kotlarmilos:improvement/r2r-emit-symbols-prop

Conversation

@kotlarmilos

Copy link
Copy Markdown
Member

Description

This PR updates PublishReadyToRunEmitSymbols to allow it to be overridden. It aligns the behavior with the SDK mirror.

@kotlarmilos kotlarmilos self-assigned this Nov 6, 2025
@kotlarmilos kotlarmilos added the os-ios Apple iOS label Nov 6, 2025
@kotlarmilos kotlarmilos added this to the 11.0.0 milestone Nov 6, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the PublishReadyToRunEmitSymbols property initialization to respect user-provided values. Previously, the property was unconditionally set to false for Apple platforms (iOS, tvOS, macOS Catalyst), which prevented users from overriding this behavior.

Key Changes:

  • Modified the condition for PublishReadyToRunEmitSymbols to only set it to false when the property hasn't been explicitly set by the user

@kotlarmilos

Copy link
Copy Markdown
Member Author

/azp run runtime-ioslike

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos

kotlarmilos commented Nov 7, 2025 •

Copy link
Copy Markdown
Member Author

I think arcade overrides PublishReadyToRunEmitSymbols in https://github.com/dotnet/arcade/blob/7d717a49d570577936361c14de38bf61271aa274/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L10

iOS build is failing with the System.NotImplementedException: iOS

@jkoritzinsky

Copy link
Copy Markdown
Member

We can change arcade to not forcibly override it.

@jkoritzinsky

Copy link
Copy Markdown
Member

Arcade PR here: dotnet/arcade#16281

@kotlarmilos

Copy link
Copy Markdown
Member Author

/ba-g #121838

@kotlarmilos
kotlarmilos merged commit bda571b into dotnet:main Nov 20, 2025
156 of 158 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants