Repository navigation
Adding GetAppDomainData cDAC API - #117827
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the GetAppDomainData cDAC API implementation, providing a new contract-based approach for retrieving application domain information. The implementation exposes app domain stage, assembly counts, heap information, and other critical metadata through the data contract reader.
- Added SystemDomain and enhanced LoaderAllocator data contracts with heap field mappings
- Implemented GetAppDomainData method in SOSDacImpl with comprehensive validation against legacy implementation
- Extended ILoader contract with new methods for retrieving domain stage, activity status, and heap allocators
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SOSDacImpl.cs | Added complete GetAppDomainData implementation with DEBUG validation against legacy DAC |
| ISOSDacInterface.cs | Added DacpAppDomainData struct definition |
| SystemDomain.cs | New data contract class for SystemDomain with GlobalLoaderAllocator field |
| LoaderAllocator.cs | Added heap pointer fields (HighFrequency, LowFrequency, Stub) |
| AppDomain.cs | Added Stage field for lifecycle tracking |
| Loader_1.cs | Implemented new ILoader methods and DacpAppDomainDataStage enum |
| Constants.cs | Added DefaultADID global constant |
| DataType.cs | Added SystemDomain data type |
| ILoader.cs | Extended interface with stage, activity, and heap allocator methods |
| loaderallocator.hpp | Added cdac_data template specialization for heap fields |
| appdomain.hpp | Updated Stage enum type and added cdac_data fields |
| datadescriptor.h | Added CDAC type and field definitions for new contracts |
| Loader.md | Updated documentation with new API methods and data structures |
31 of 32 tasks
Open
3 tasks
jkotas
reviewed
Jul 20, 2025
rcj1
marked this pull request as draft
July 20, 2025 20:43
rcj1
marked this pull request as ready for review
July 21, 2025 03:57
max-charlamb
requested changes
Jul 21, 2025
…to GetAppDomainData
jkotas
reviewed
Jul 22, 2025
jkotas
reviewed
Jul 22, 2025
jkotas
reviewed
Jul 22, 2025
jkotas
reviewed
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.