Skip to content

Delete DacVirtualUnwind - #116286

Merged
jkotas merged 3 commits into
dotnet:mainfrom
jkotas:DacVirtualUnwind
Jun 5, 2025
Merged

jkotas merged 3 commits into
dotnet:mainfrom
jkotas:DacVirtualUnwind

Conversation

@jkotas

@jkotas jkotas commented Jun 4, 2025

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings June 4, 2025 02:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the obsolete DacVirtualUnwind functionality, eliminating both its declaration and implementation for TARGET_UNIX builds.

  • Removed DacVirtualUnwind declaration from src/coreclr/inc/daccess.h.
  • Removed DacVirtualUnwind implementation and related helper functions from src/coreclr/debug/daccess/dacfn.cpp.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/coreclr/inc/daccess.h Removed DacVirtualUnwind function declaration
src/coreclr/debug/daccess/dacfn.cpp Removed DacVirtualUnwind implementation and associated code

@jkotas

jkotas commented Jun 4, 2025

Copy link
Copy Markdown
Member Author

Missed in #116085

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@jkotas
jkotas requested a review from max-charlamb June 4, 2025 02:46
@jkotas
jkotas force-pushed the DacVirtualUnwind branch from 60cd4f3 to ced3bed Compare June 4, 2025 16:32
Comment thread src/coreclr/vm/frames.h Resolved
@jkotas
jkotas force-pushed the DacVirtualUnwind branch from ced3bed to 4cce6f7 Compare June 4, 2025 20:29
@jkotas
jkotas force-pushed the DacVirtualUnwind branch from 4cce6f7 to 65c171b Compare June 4, 2025 20:30
Comment thread src/coreclr/vm/frames.h Resolved
@jkotas
jkotas merged commit c7dea1c into dotnet:main Jun 5, 2025
@jkotas
jkotas deleted the DacVirtualUnwind branch June 5, 2025 05:26
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants