Skip to content

Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text - #102885

Closed
MohamedChaawa wants to merge 1 commit into
dotnet:mainfrom
MohamedChaawa:patch-1
Closed

Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text#102885
MohamedChaawa wants to merge 1 commit into
dotnet:mainfrom
MohamedChaawa:patch-1

Conversation

@MohamedChaawa

@MohamedChaawa MohamedChaawa commented May 30, 2024

Copy link
Copy Markdown

Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text
Issue: #86490

@MohamedChaawa
Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text
252f58d 
Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text 
Issue: #86490
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label May 30, 2024
@dotnet-policy-service

dotnet-policy-service Bot commented May 30, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

@MohamedChaawa

MohamedChaawa commented May 30, 2024

Copy link
Copy Markdown
Author

Can you please review this PR? @SamMonoRT @roji @ajcvickers

stephentoub
stephentoub reviewed May 30, 2024
View reviewed changes
Comment thread src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcDataReader.cs
if (0 == lengthOrIndicator)
{
break; // done
}

@stephentoub stephentoub May 30, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to add a test for this?

@SamMonoRT
SamMonoRT requested review from AndriySvyryd and roji May 31, 2024 14:17
@MohamedChaawa

MohamedChaawa commented Jun 21, 2024

Copy link
Copy Markdown
Author

@roji @AndriySvyryd Any news about this pullrequest review please?
This bug is blocking our projet development advancements.

@roji

roji commented Jun 21, 2024

Copy link
Copy Markdown
Member

@MohamedChaawa can you please address the comment above about adding a test?

@stephentoub stephentoub added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 23, 2024
@dotnet-policy-service

dotnet-policy-service Bot commented Jul 7, 2024

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

danmoseley
danmoseley reviewed Jul 7, 2024
View reviewed changes
Comment thread src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcDataReader.cs
// followed by exception. I did not add it now to avoid breaking change
Debug.Assert(lengthOrIndicator >= 0 || lengthOrIndicator == ODBC32.SQL_NO_TOTAL, "unexpected lengthOrIndicator value");

if (0 == lengthOrIndicator)

@danmoseley danmoseley Jul 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (0 == lengthOrIndicator)
if (lengthOrIndicator == 0)

@dotnet-policy-service

dotnet-policy-service Bot commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@github-actions github-actions Bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roji roji Awaiting requested review from roji
@AndriySvyryd AndriySvyryd Awaiting requested review from AndriySvyryd
@stephentoub stephentoub Awaiting requested review from stephentoub
1 more reviewer
@danmoseley danmoseley danmoseley left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Data.Odbc community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MohamedChaawa @roji @stephentoub @danmoseley