Repository navigation

Ban SR.GetResourceString #81338

Closed

Labels

area-NativeAOT-coreclrsize-reduction

Milestone

MichalStrehovsky

opened

on Jan 29, 2023

We should forbid calling SR.GetResourceString directly. This throws off size optimizations that try to get rid of the unused resource strings like #80896. We need to clean these up and enable enforcement.

Microsoft.CSharp, Microsoft.VisualBasic, System.ComponentModel seem to be the worst offenders.

MichalStrehovsky
added
size-reductionIssues impacting final app size primary for size sensitive workloads

area-NativeAOT-coreclr
on Jan 29, 2023
MichalStrehovsky
added this to the 8.0.0 milestone on Jan 29, 2023
agocke
added this to AppModelon Mar 6, 2023
agocke
modified the milestones: 8.0.0, Future on Apr 6, 2023
MichalStrehovsky
added a commit that references this issue on Jun 22, 2023
Remove uses of SR.GetResourceString through the libs
8718892
ghost added
in-prThere is an active PR which will close this issue when it is merged
on Jun 22, 2023
MichalStrehovsky
closed this as completedin #87912 on Jun 23, 2023
MichalStrehovsky
added a commit that references this issue on Jun 23, 2023
Remove uses of SR.GetResourceString throughout the libs (#87912)
a0e670a
ghost removed
in-prThere is an active PR which will close this issue when it is merged
on Jun 23, 2023
ghost locked as resolved and limited conversation to collaborators on Jul 23, 2023

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

area-NativeAOT-coreclrsize-reduction

Type

No type

Projects

AppModel
Status
No status

Milestone

FutureNo due date

Relationships

None yet

Development

No branches or pull requests