Skip to content

Incorrect translation of Ping error codes #62592

Closed

Description

@filipnavara

Spotted in #62559:

On non-Windows the error code in raw-socket Ping code path is translated incorrectly:

In the non-privileged code path running the ping command line utility it will presumably return TimeExceeded without an address. The SendPingToExternalHostWithLowTtlTest outer loop test should be modified accordingly to detect this case.

Activity

  1. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Dec 9, 2021
  2. added
    enhancementProduct code improvement that does NOT require public API changes/additions
    help wanted[up-for-grabs] Good issue for external contributors
    and removed
    untriagedNew issue has not been triaged by the area owner
    on Dec 14, 2021
  3. added this to the Future milestone on Dec 14, 2021
  4. karelz commented on Dec 14, 2021

    @karelz
    Member

    Triage: Would be good to have. Should be fairly straightforward.

  5. added
    good first issueIssue should be easy to implement, good for first-time contributors
    on Dec 30, 2021
  6. deeprobin commented on Dec 31, 2021

    @deeprobin
    Contributor

    Feel free to assign me 😄

  7. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Dec 31, 2021
  8. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Jan 8, 2022
  9. modified the milestones: Future, 7.0.0 on Jan 11, 2022
  10. ghost locked as resolved and limited conversation to collaborators on Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-System.NetenhancementProduct code improvement that does NOT require public API changes/additionsgood first issueIssue should be easy to implement, good for first-time contributorshelp wanted[up-for-grabs] Good issue for external contributors

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions