Skip to content

Mark TypeBuilder.DefinePInvokeMethod as RequiresUnreferencedCode #45703

New issue
New issue
Closed
#56537
Closed
Mark TypeBuilder.DefinePInvokeMethod as RequiresUnreferencedCode#45703
#56537
Assignees
krwq
Labels
area-System.Reflection.Emitlinkable-frameworkIssues associated with delivering a linker friendly framework
Milestone
6.0.0

Description

@MichalStrehovsky
MichalStrehovsky
opened on Dec 7, 2020

#45633 (comment)

If linker didn't see the p/invoke, it would not have done the necessary work to ensure the generated marshalling code for the p/invoke can work (constructors might be missing for types used in out positions of the signature, the p/invoke might introduce COM into the process etc.).

We should put RequiresUnreferencedCodeAttribute on all overloads in the ref assembly and all the implementations.

Activity

  1. MichalStrehovsky
    added
    linkable-frameworkIssues associated with delivering a linker friendly framework
    on Dec 7, 2020
  2. MichalStrehovsky
    added this to the 6.0.0 milestone on Dec 7, 2020

  3. Dotnet-GitSync-Bot commented on Dec 7, 2020

    @Dotnet-GitSync-Bot
    Dotnet-GitSync-Bot
    on Dec 7, 2020
    Collaborator

    I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

  4. Dotnet-GitSync-Bot
    added
    untriagedNew issue has not been triaged by the area owner
    on Dec 7, 2020
  5. jkotas
    added
    area-System.Reflection.Emit
    on Dec 7, 2020
  6. joperezr
    removed
    untriagedNew issue has not been triaged by the area owner
    on Feb 4, 2021
  7. krwq
    added
    help wanted[up-for-grabs] Good issue for external contributors
    on Jul 22, 2021
  8. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Jul 29, 2021
  9. krwq
    self-assigned this
    on Jul 29, 2021
  10. eerhardt
    removed
    help wanted[up-for-grabs] Good issue for external contributors
    on Jul 30, 2021
  11. krwq
    closed this as completedin #56537on Aug 5, 2021
  12. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Aug 5, 2021
  13. ghost locked as resolved and limited conversation to collaborators on Sep 7, 2021
  14. joperezr
    added this to Triage POD for Reflection, META, etc.on Nov 2, 2021
  15. joperezr
    moved this to Done in Triage POD for Reflection, META, etc.on Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-System.Reflection.Emitlinkable-frameworkIssues associated with delivering a linker friendly framework

Type

No type

Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions