Repository navigation
Most CoreCLR tests not running in CI. #35798
Description
There are several issues currently.
The most significant is that the targetGeneric tests are not currently running in CI.
The root cause of this is the unzipping of the targetSpecific and targetGeneric tests into the same directory is broken, because the second download clean the directory removing the targetGeneric tests. The draft fix is #35699.
It also turns out that #35645 fix to eliminate the targetSpecific build legs would also fix the directory cleaning issue.
However #35699 & #35645 both demonstrates another set of issues.
- The generic tests include Linux specific tests. When run on Windows these fail.
- The specific tests are missing WIndows specific tests.
So in general
- any test which doesn't run on OSX is not being built in the
targetGenericphase. - any test which doesn't run on every target cannot be treated as
targetGeneric
The current proposed solution is #35783. This test allows tests for all targets to be build on any platform. It builds all tests on OSX and removes obsolete build legs and cleans up residue.
/cc @dotnet/runtime-infrastructure
Activity
[-]All CoreCLR tests not running in CI.[/-][+]Most CoreCLR tests not running in CI.[/+]sdmaclea commentedon May 6, 2020
Coverage gap is being fixed by #35868
sdmaclea commentedon May 6, 2020
The following tests regressed during the coverage gap.
commit b653f7942c415328bf2a22ab61be58da94794b90 Author: Steve MacLean <Steve.MacLean@Microsoft.com> Date: Tue May 5 17:12:44 2020 -0400 Add issues related to CI coverage outage diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index ce48665..d57765f 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -11,6 +11,25 @@ <ExcludeList Include="$(XunitTestBinBase)/Regressions/coreclr/GitHub_22888/test22888/*"> <Issue>https://github.com/dotnet/runtime/issues/13703</Issue> </ExcludeList> + <!-- Test regressions during CI coverage outage --> + <ExcludeList Include="$(XunitTestBinBase)/baseservices/exceptions/stackoverflow/stackoverflowtester/*"> + <Issue>https://github.com/dotnet/runtime/issues/35798</Issue> + </ExcludeList> + <ExcludeList Include="$(XunitTestBinBase)/JIT/SIMD/Vector3Interop_r/*"> + <Issue>https://github.com/dotnet/runtime/issues/35798</Issue> + </ExcludeList> + <ExcludeList Include="$(XunitTestBinBase)/JIT/SIMD/Vector3Interop_ro/*"> + <Issue>https://github.com/dotnet/runtime/issues/35798</Issue> + </ExcludeList> + <ExcludeList Include="$(XunitTestBinBase)/Interop/StructMarshalling/ReversePInvoke/MarshalSeqStruct/ReversePInvoke/ReversePInvokeTest/*"> + <Issue>https://github.com/dotnet/runtime/issues/35798</Issue> + </ExcludeList> + <ExcludeList Include="$(XunitTestBinBase)/Interop/PInvoke/Vector2_3_4/Vector2_3_4/*"> + <Issue>https://github.com/dotnet/runtime/issues/35798</Issue> + </ExcludeList> + <ExcludeList Include="$(XunitTestBinBase)/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyTest/*"> + <Issue>https://github.com/dotnet/runtime/issues/35798</Issue> + </ExcludeList> </ItemGroup> <!-- All OS/Arch CoreCLR excludes -->sdmaclea commentedon May 6, 2020
The regressions were found while testing 96268f3
The CI coverage was introduced by #35378 so untested coverage began around commit d56f849
sdmaclea commentedon May 6, 2020
/cc @janvorli for the regressing
stackoverflowtestertest/cc @BruceForstall @tannergooding @echesakovMSFT
for the regressing
SIMD/Vector3Interop*tests/cc @AaronRobinsonMSFT for the regressing
InterOptests.jashook commentedon May 6, 2020
Closing, we are now back to 29 workitems.
tannergooding commentedon May 6, 2020
This looks to be for @AaronRobinsonMSFT as well. They are all related to
Non-blittable parameter types are invalid for UnmanagedCallersOnly methods., which I wouldn't expect forVector2,Vector3, orVector4which should all be blittable and classified as "user-defined" structs for ABI and marshaling purposes.AaronRobinsonMSFT commentedon May 6, 2020
@tannergooding The issue is related to returned
ValueTypesfor delegates marked withUnmanagedCallersOnlyAttributes- which is now done automatically.runtime/src/coreclr/src/vm/dllimport.cpp
Lines 3506 to 3520 in f4a67df
I will update the location where we implicitly mark reverse P/Invokes with
UnmanagedCallersOnlyAttributes.runtime/src/coreclr/src/vm/ilstubcache.cpp
Lines 296 to 305 in f4a67df
/cc @jkotas
AaronRobinsonMSFT commentedon May 6, 2020
Hmm can't do that it seems... I will need to dig more into this.