Skip to content

Move ILVerify tool to dotnet/runtime repo #13827

Closed

Description

@jkotas

Activity

  1. jkotas commented on Dec 9, 2019

    @jkotas
    MemberAuthor
  2. Entomy commented on Dec 23, 2019

    @Entomy

    As mentioned in dotnet/corert#7923, there's a use case for ILVerify in ILSupport and demand.

    ILSupport is an extension for VisualStudio providing... IL support. As far as I know, it's the only IL syntax classifier, and also provides project templates. The use case here is obvious, as verification should be done as part of the build process.

    I happen to do language R&D, and there's an obvious use case there as well, in making sure I've got valid IL coming out of a compiler.

  3. transferred this issue fromdotnet/coreclron Jan 31, 2020
  4. am11 commented on Feb 4, 2020

    @am11
    Member
  5. GSPP commented on Feb 23, 2020

    @GSPP

    Another use case is verifying custom generated DLLs as a debugging aid. Invalid IL can be hard to detect and diagnose from just execution alone.

  6. added this to the 5.0 milestone on May 11, 2020
  7. removed
    untriagedNew issue has not been triaged by the area owner
    on May 11, 2020
  8. ViktorHofer commented on May 29, 2020

    @ViktorHofer
    Member

    Would it make more sense to move the sources into the Arcade repository which allows easier packaging and serves as a central place for other repositories to consume assets?

  9. jkotas commented on May 29, 2020

    @jkotas
    MemberAuthor

    ilverify is in the same category as ilasm or ildasm. It is a generally applicable tool, not tied to .NET product engineering infrastructure. .NET Framework SDK includes equivalent tool called peverify. ilverify is the replacement for peverify.

    Also, 90% of the ilverify code is shared with other components in CoreCLR. If we were to build it somewhere else, we would need to setup a source mirroring for this.

  10. ViktorHofer commented on May 29, 2020

    @ViktorHofer
    Member

    Also, 90% of the ilverify code is shared with other components in CoreCLR

    I see, then it makes sense to live in dotnet/runtime. Thanks for clarifying.

  11. BruceForstall commented on Jun 3, 2020

    @BruceForstall
    Contributor

    @agocke @jkotas After #35038, is this complete (can be closed)?

  12. jkotas commented on Jun 3, 2020

    @jkotas
    MemberAuthor

    Yes, this can be closed. I have verified that the package is produced by the official build.

  13. ghost locked as resolved and limited conversation to collaborators on Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions