Repository navigation
fix(analyzers): report RCS1046 for async void methods - #1790
Merged
Merged
Conversation
Async methods without the Async suffix were only reported when the return type was awaitable, so async void methods were skipped. Fixes #1770 Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 16, 2026
Closed
This was referenced Oct 12, 2026
Closed
This was referenced Oct 19, 2026
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async voidmethods whose names do not end withAsyncasync void Foo()Fixes #1770
Test plan
dotnet test src/Tests/Analyzers.Tests/Analyzers.Tests.csproj --filter FullyQualifiedName~RCS1046AsynchronousMethodNameShouldEndWithAsyncTestsMade with Cursor