Skip to content

Remove redundant Mono RuntimeArtifactsPath arguments - #5351

Open
jkoritzinsky wants to merge 1 commit into
dotnet:mainfrom
jkoritzinsky:jkoritzinsky-runtime-artifact-alias-cleanup
Open

jkoritzinsky wants to merge 1 commit into
dotnet:mainfrom
jkoritzinsky:jkoritzinsky-runtime-artifact-alias-cleanup

Conversation

@jkoritzinsky

Copy link
Copy Markdown
Member

Summary

Remove the redundant RuntimeArtifactsPath argument from the local Mono benchmark script and all four Linux/Windows Mono Interpreter/JIT setup examples. The supplied path already matches the runtime's default Mono artifacts directory, so no replacement override is needed.

Preserve RuntimeFlavor=mono, Release configuration, OS/architecture selection, and the existing benchmark layout steps. This supports the runtime alias cleanup in dotnet/runtime#133115.

Validation

  • Passed Python syntax compilation and 108 mocked Mono dependency-generation scenarios covering Windows/Linux/macOS, four architectures, Interpreter/JIT/both, and cached/uncached/forced regeneration.
  • Passed exact documentation comparison: only the four redundant path arguments changed.
  • Passed the repository's Markdown lint configuration using markdownlint-cli@0.45.0.
  • Passed git diff --check; no RuntimeArtifactsPath references remain in the checkout.
  • Runtime builds and benchmarks were not run.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 3, 2026 23:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Mono artifacts-path override cleanup.

No open issues 🎉

What changed in this PR

Removes redundant Mono RuntimeArtifactsPath overrides from the local benchmark workflow, relying on the runtime’s default artifacts directory and supporting the alias cleanup in dotnet/runtime#133115.

Changes:

  • Removes the path override from the script’s Mono libs.pretest invocation.
  • Updates all four Linux/Windows Interpreter/JIT setup examples while preserving RuntimeFlavor=mono, build settings, and benchmark layout steps.
File Description
scripts/​benchmarks_local.py Removes the redundant Mono artifacts path argument.
docs/​benchmarking-workflow-dotnet-runtime.md Removes the same argument from four Mono setup examples.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants