Repository navigation
Remove redundant Mono RuntimeArtifactsPath arguments - #5351
Open
jkoritzinsky wants to merge 1 commit into
Open
jkoritzinsky wants to merge 1 commit into
jkoritzinsky wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the Mono artifacts-path override cleanup.
No open issues 🎉
What changed in this PR
Removes redundant Mono RuntimeArtifactsPath overrides from the local benchmark workflow, relying on the runtime’s default artifacts directory and supporting the alias cleanup in dotnet/runtime#133115.
Changes:
- Removes the path override from the script’s Mono
libs.pretestinvocation. - Updates all four Linux/Windows Interpreter/JIT setup examples while preserving
RuntimeFlavor=mono, build settings, and benchmark layout steps.
| File | Description |
|---|---|
| scripts/benchmarks_local.py | Removes the redundant Mono artifacts path argument. |
| docs/benchmarking-workflow-dotnet-runtime.md | Removes the same argument from four Mono setup examples. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the redundant
RuntimeArtifactsPathargument from the local Mono benchmark script and all four Linux/Windows Mono Interpreter/JIT setup examples. The supplied path already matches the runtime's default Mono artifacts directory, so no replacement override is needed.Preserve
RuntimeFlavor=mono, Release configuration, OS/architecture selection, and the existing benchmark layout steps. This supports the runtime alias cleanup in dotnet/runtime#133115.Validation
markdownlint-cli@0.45.0.git diff --check; noRuntimeArtifactsPathreferences remain in the checkout.