Repository navigation
fix parsing .editorconfig line endings, add a unit test - #10736
Closed
JanProvaznik wants to merge 1 commit into
Closed
JanProvaznik wants to merge 1 commit into
JanProvaznik wants to merge 1 commit into
Conversation
Member
Author
|
@dotnet-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10684
Context
editorconfig settings were ignored due to being incapable of parsing it if they had different line endings than the current system uses
Changes Made
use StreamReader instead of string.Split
Testing
unit test that file with multiple line endings is parsed correctly
Notes
This is the fix that should go to main, a simpler fix #10740 goes to servicing.