Repository navigation
Prepare SR13 for servicing packages - #39774
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 30a901d0-ec5e-4ba0-8c8f-c351f143da0a
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 39774Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 39774" |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔵 Needs a closer look
Release-wide build and package validation with the pinned servicing toolset remains outstanding, as the supplied evidence only covers property evaluation using a different SDK, not produced or signed artifacts.
No open issues 🎉
What changed in this PR
Prepares .NET MAUI 10 SR13 for stable servicing packages on release/10.0.1xx-sr13, following the SR11/SR12 versioning pattern. This configuration-only change does not resolve outstanding validation failures or authorize release.
Changes:
- Replaces the CI prerelease labels and inflight override with a single
servicinglabel. - Enables package stabilization by default while preserving explicit overrides, patch version
130, and SDK band10.0.100.
| File | Description |
|---|---|
eng/Versions.props |
Sets servicing versioning and defaults to stable packages for SR13. |
Review effort: Balanced
|
@dalexsoto stamp |
PureWeen
left a comment
There was a problem hiding this comment.
Adversarial review
No new actionable defects found at 6abec827bd31f0082cadf810dc764dcee4b291e8.
Each independent reviewer read the complete eng/Versions.props source and its single changed hunk, then traced the affected versioning, workload, and packaging consumers. The authoritative GitHub snapshot contains exactly one changed file (+2/-3). The title and description accurately describe this focused SR13 servicing flip.
Independent head/base MSBuild property evaluations confirmed the intended transition: default and inflight cases now select servicing, enable stabilization, and leave the workload suffix empty; explicit StabilizePackageVersion=false remains honored and produces -servicing. Patch 130 and SDK band 10.0.100 are unchanged.
Coverage and limits: No automated tests were added in this configuration-only diff. Six isolated property cases were checked with installed SDK 11.0.100-rc.3.26522.148, not the unavailable pinned 10.0.113-servicing.26454.107 toolset. These checks do not establish full-project package generation, signed-artifact correctness, or runtime behavior; no build, pack, device, or UI test was run as part of this review.
Prior feedback: The existing review and complete issue-comment inventory were checked for duplicate claims. No inline review comments were present; thread-resolution metadata was not queried. The already-noted full-package validation limitation is not raised as a new defect.
Methodology: 3 independent reviewers with adversarial consensus; all reported no verified PR-caused defects.
Scope: code review only. CI/check status and merge readiness were not evaluated; use the repository's CI-analysis workflow for that assessment.
[!NOTE]
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Explicit release-target exception: this focused release-preparation PR intentionally targets
release/10.0.1xx-sr13, notmain, as requested after the SR13 branch was created from candidate07024e2926da3730e23bafa85719967f8f95bf97(#39597).Apply the established SR11/SR12 servicing flip (#38464, #39490), changing only
eng/Versions.props:ci.mainand the conditionalinflight/currentci.inflightoverride with onePreReleaseVersionLabel=servicing.StabilizePackageVersiontotrue, preserving explicit overrides.PatchVersion=130,SdkBandVersion=10.0.100, and all unrelated content.The delta is one file, two insertions and three deletions. No matching open or recently merged SR13 servicing PR was found; the exact SR13 target also had no PRs at the final pre-push check. There is no
mainversion bump or SR14 milestone; the next release preparation is .NET 11 SR1. Closed #39600 is not reopened.Validation
All commands below passed (exit code 0), using local SDK
11.0.100-preview.6.26359.118/ MSBuild18.9.0.36018:Result: well-formed XML; no whitespace errors. Existing formatting is preserved. No configuration tests were added.
Result for both: major/minor/patch
10.0.130, SDK band10.0.100, labelservicing,IsServicingBuild=true,StabilizePackageVersion=true,DotNetFinalVersionKind=release, empty workload suffix, andSdkBandVersionForWorkload_FromRuntimeVersions=10.0.100. The former inflight trigger no longer overrides the servicing label.Result: explicit
StabilizePackageVersion=falseremains honored; labelservicing,IsServicingBuild=true, emptyDotNetFinalVersionKind, workload suffix-servicing, and workload band10.0.100-servicing. Patch and SDK band remain unchanged.Result for both actual Core project evaluations:
PackageVersion=10.0.130andVersion=10.0.130, with the same stable servicing properties above.Limitations: the pinned
10.0.113-servicing.26454.107toolset is not installed (dotnet --list-sdkschecked). These are MSBuild property evaluations only, not an official build, pack, signed-artifact, or runtime validation. No unit/device/UI tests were run for this configuration-only change.Remaining release gates — not ship approval
Candidate
07024e2926da3730e23bafa85719967f8f95bf97is cut. Its supplied validation evidence is: build pipeline 1655781 passed, device run 1655779 failed, and UI run 1655780 failed. This versioning-only PR does not fix or clear those failures and is not ship approval.PR review/CI, investigation and disposition of the failed device/UI runs, and final stabilized release-head build/package/runtime validation remain required before a human ship decision. No direct release-branch push, merge, tag, package promotion, or release-pipeline dispatch is part of this PR.
Issues Fixed
N/A - SR13 release preparation; this does not fix a product bug.