Skip to content

[Candidate-TestFailure][Windows] Render registered toolbar font icons through the image service - #39750

Merged
kubaflo merged 1 commit into
dotnet:inflight/candidatefrom
sheiksyedm:fix/windows-toolbar-custom-font-icons
Oct 29, 2026
Merged

kubaflo merged 1 commit into
dotnet:inflight/candidatefrom
sheiksyedm:fix/windows-toolbar-custom-font-icons

Conversation

@sheiksyedm

Copy link
Copy Markdown
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Targets inflight/candidate as a follow-up to #39685.

The Windows ToolbarItemFontIconSourceChangesAtRunTime screenshot test failed in candidate PR #39597, with a missing toolbar glyph reported while the page image continued to render correctly.

For registered app fonts such as FontAwesome, render toolbar icons through MAUI's existing font-image service and place the resulting image in AppBarButton.Icon. This preserves the icon-plus-label presentation introduced by #39685 while avoiding native FontIcon rendering for these custom fonts. Default/system fonts retain the native rendering path.

Image conversion explicitly uses the toolbar's MauiContext, since a replacement image source can be converted before it is attached to its logical parent.

This is a proposed mitigation: the original CI failure did not reproduce locally, so its root cause and resolution in CI remain unconfirmed. This change does not skip the test or update screenshot baselines.

Issues Fixed

Addresses the reported Windows toolbar screenshot failure in #39597 following #39685.
Preserves the icon-plus-text behavior for #39537.

@dotnet-policy-service dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Oct 29, 2026
@azure-pipelines

This comment has been minimized.

@sheiksyedm sheiksyedm added the community ✨ Community Contribution label Oct 29, 2026
@sheiksyedm
sheiksyedm requested a balanced review from Copilot October 29, 2026 10:04
@sheiksyedm

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@sheiksyedm
sheiksyedm marked this pull request as draft October 29, 2026 10:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The CI-only Windows glyph failure was not reproduced locally, and the ImageIcon mitigation remains unconfirmed without validation in the failing Windows screenshot environment.

No open issues 🎉

What changed in this PR

Proposes a Windows toolbar rendering mitigation for the missing registered-font glyph reported in #39597, preserving the icon-plus-label behavior introduced by #39685. Resolution of the original CI failure remains unconfirmed.

Changes:

  • Render registered app-font icons through MAUI’s image service into AppBarButton.Icon, retaining native rendering for default/system fonts.
  • Pass the toolbar’s MauiContext explicitly during image conversion so replacement sources can load before parent attachment.
File Description
src/​Controls/​src/​Core/​Toolbar/​Toolbar.Windows.cs Routes registered-font icons through the image service and supplies context explicitly.
src/​Controls/​src/​Core/​Platform/​Windows/​ImageConverter.cs Accepts an explicit IMauiContext, falling back to context lookup on the source.

Review effort: Balanced

@kubaflo

This comment has been minimized.

@github-actions github-actions Bot added the s/agent-review-in-progress AI review is currently running for this PR label Oct 29, 2026
@MauiBot

MauiBot commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

PR Test Gate

@sheiksyedm — existing-test verification for commit 3fa03545.

Result SKIPPED Platform Android Commit 3fa03545


🧪 Gate analysis — click to expand

⚠ Skipped. No runnable PR tests were selected. The fix has not been verified by this gate.

No interpretable test-group summary was produced. No additional test execution is inferred.

PR head: 3fa03545.

Without-fix baseline: 6e501be7.

@MauiBot MauiBot removed the s/agent-review-in-progress AI review is currently running for this PR label Oct 29, 2026
@sheiksyedm
sheiksyedm marked this pull request as ready for review October 29, 2026 12:48
@kubaflo
kubaflo merged commit 388dfb7 into dotnet:inflight/candidate Oct 29, 2026
199 of 215 checks passed
@github-actions github-actions Bot added this to the .NET 10 SR13 milestone Oct 29, 2026

This branch was previously deployed

1 inactive deployment
copilot-pat-pool — 3fa03545 Deployed Oct 29, 2026 by sheiksyedm via conclusion #2573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants