Repository navigation
[Candidate-TestFailure][Windows] Render registered toolbar font icons through the image service - #39750
Merged
kubaflo merged 1 commit intoOct 29, 2026
Conversation
sheiksyedm
temporarily deployed
to
copilot-pat-pool
October 29, 2026 10:00 — with
GitHub Actions
Inactive
sheiksyedm
temporarily deployed
to
copilot-pat-pool
October 29, 2026 10:00 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
sheiksyedm
temporarily deployed
to
copilot-pat-pool
October 29, 2026 10:01 — with
GitHub Actions
Inactive
sheiksyedm
temporarily deployed
to
copilot-pat-pool
October 29, 2026 10:03 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sheiksyedm
temporarily deployed
to
copilot-pat-pool
October 29, 2026 10:05 — with
GitHub Actions
Inactive
sheiksyedm
temporarily deployed
to
copilot-pat-pool
October 29, 2026 10:05 — with
GitHub Actions
Inactive
sheiksyedm
marked this pull request as draft
October 29, 2026 10:06
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The CI-only Windows glyph failure was not reproduced locally, and the ImageIcon mitigation remains unconfirmed without validation in the failing Windows screenshot environment.
No open issues 🎉
What changed in this PR
Proposes a Windows toolbar rendering mitigation for the missing registered-font glyph reported in #39597, preserving the icon-plus-label behavior introduced by #39685. Resolution of the original CI failure remains unconfirmed.
Changes:
- Render registered app-font icons through MAUI’s image service into
AppBarButton.Icon, retaining native rendering for default/system fonts. - Pass the toolbar’s
MauiContextexplicitly during image conversion so replacement sources can load before parent attachment.
| File | Description |
|---|---|
| src/Controls/src/Core/Toolbar/Toolbar.Windows.cs | Routes registered-font icons through the image service and supplies context explicitly. |
| src/Controls/src/Core/Platform/Windows/ImageConverter.cs | Accepts an explicit IMauiContext, falling back to context lookup on the source. |
Review effort: Balanced
This comment has been minimized.
This comment has been minimized.
Collaborator
PR Test Gate
|
sheiksyedm
marked this pull request as ready for review
October 29, 2026 12:48
Open
3 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Targets
inflight/candidateas a follow-up to #39685.The Windows
ToolbarItemFontIconSourceChangesAtRunTimescreenshot test failed in candidate PR #39597, with a missing toolbar glyph reported while the page image continued to render correctly.For registered app fonts such as FontAwesome, render toolbar icons through MAUI's existing font-image service and place the resulting image in
AppBarButton.Icon. This preserves the icon-plus-label presentation introduced by #39685 while avoiding nativeFontIconrendering for these custom fonts. Default/system fonts retain the native rendering path.Image conversion explicitly uses the toolbar's
MauiContext, since a replacement image source can be converted before it is attached to its logical parent.This is a proposed mitigation: the original CI failure did not reproduce locally, so its root cause and resolution in CI remain unconfirmed. This change does not skip the test or update screenshot baselines.
Issues Fixed
Addresses the reported Windows toolbar screenshot failure in #39597 following #39685.
Preserves the icon-plus-text behavior for #39537.