Repository navigation
[Inflight/Candidate] Stabilize Looped CarouselView Collection Override Device Test - #39217
Merged
kubaflo merged 1 commit intoOct 13, 2026
Conversation
HarishwaranVijayakumar
temporarily deployed
to
copilot-pat-pool
October 7, 2026 10:43 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
Hey there @@HarishwaranVijayakumar! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
Bot
added
the
partner/syncfusion
HarishwaranVijayakumar
temporarily deployed
to
copilot-pat-pool
October 7, 2026 10:43 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
HarishwaranVijayakumar
temporarily deployed
to
copilot-pat-pool
October 7, 2026 10:44 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
HarishwaranVijayakumar
temporarily deployed
to
copilot-pat-pool
October 7, 2026 10:50 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
HarishwaranVijayakumar
temporarily deployed
to
copilot-pat-pool
October 7, 2026 10:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
HarishwaranVijayakumar
temporarily deployed
to
copilot-pat-pool
October 7, 2026 10:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
Contributor
|
/azp run |
github-actions
Bot
added
the
s/agent-review-in-progress
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Contributor
|
Note 🔍
|
This comment has been minimized.
This comment has been minimized.
MauiBot
added
s/agent-review-incomplete
This was referenced Oct 7, 2026
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
added
the
s/agent-review-in-progress
Contributor
|
Note 🔍
|
This comment has been minimized.
This comment has been minimized.
MauiBot
removed
the
s/agent-review-in-progress
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
added
the
s/agent-review-in-progress
Contributor
|
Note 🔍
|
This comment has been minimized.
This comment has been minimized.
MauiBot
removed
the
s/agent-review-in-progress
This comment has been minimized.
This comment has been minimized.
Contributor
Tests Failure Analysis
🧪 CI Analysis — click to expand📊 maui-prNo failures found. 🧪 maui-pr-devicetests
🧪 maui-pr-uitests
🧭 Follow-up — actions and refreshNext action: Restore complete results/crash diagnostics and historical runtime/handler provenance; compare equivalent fixtures before attributing unresolved failures.
|
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
added
the
s/agent-review-in-progress
Contributor
|
Note 🔍
|
Collaborator
AI Review Summary
Review status: Evidence-first output is incomplete. Missing or skipped required artifacts cannot support approval; existing Gate and blocking findings remain authoritative. 🗂️ Review Sessions — click to expand🚦 Gate — Test Before & After FixGate Result: ❌ FAILEDThe trusted test-verification gate reported a failure. Its detailed display artifact was Inspect the trusted Gate task logs for the failing build or test evidence. This run is not 📋 Pre-Flight — Context & ValidationThe Copilot expert-review task ended before this phase was persisted, usually because the review-stage time budget expired or the CI agent encountered a transient authentication/runtime problem. Earlier completed sections remain valid, but this review is incomplete without this phase. Next step: re-comment 🔬 Code Review — Deep AnalysisThe Copilot expert-review task ended before this phase was persisted, usually because the review-stage time budget expired or the CI agent encountered a transient authentication/runtime problem. Earlier completed sections remain valid, but this review is incomplete without this phase. Next step: re-comment 🛠️ Try-Fix — Analysis & ComparisonThe Copilot expert-review task ended before this phase was persisted, usually because the review-stage time budget expired or the CI agent encountered a transient authentication/runtime problem. Earlier completed sections remain valid, but this review is incomplete without this phase. Next step: re-comment 🏁 Report — Final RecommendationThe Copilot expert-review task ended before this phase was persisted, usually because the review-stage time budget expired or the CI agent encountered a transient authentication/runtime problem. Earlier completed sections remain valid, but this review is incomplete without this phase. Next step: re-comment 📱 UI Tests — Button,Label,LayoutDetected UI test categories: ❌ Deep UI tests — 398 passed, 5 failed, 8 skipped across 3 categories on platform-pool agent (replaces in-process counts above). 🧪 UI Test Execution Results (deep, platform pool)
❌
|
MauiBot
removed
the
s/agent-review-in-progress
HarishwaranVijayakumar
changed the title
sheiksyedm
marked this pull request as ready for review
October 13, 2026 07:04
kubaflo
pushed a commit
that referenced
this pull request
Oct 13, 2026
…e Device Test (#39217) ### Issue Details - The Windows device test `LoopedVisibleCollectionOverrideDoesNotEnterRealizationRetry` failed intermittently in #38782. - Failures occurred during high-physical-range setup or when validating that the pending override completed without entering the realization-retry path. ### Root Cause - The test assumed logical item `2` must be the **first visible physical item** after `ScrollIntoView()`. - The implementation under test, `IsCollectionCurrentItemOverrideVisible`, only requires the item to appear **anywhere within the visible range** (`FirstVisibleIndex` to `LastVisibleIndex`). - The test could continue while native scrolling, layout, and snap-point processing were still in progress. - The deferred override callback could therefore encounter an unready native state and schedule a realization retry. Diagnostics confirmed a failing run with `RetryCount = 1`. - Repeated successful runs after adding scroll-settling synchronization support a test setup/timing issue. ### Description of Change - Wrapped the initial native `ScrollIntoView()` operation in the existing `WaitForSettleAsync` helper to wait for terminal scroll events and a short quiet period. - Replaced the first-visible-item assumption with a predicate that scans the entire visible range for logical item `2` at a high physical index (`> 1000`). - Reused the predicate for both setup and final post-override validation. - Preserved the original assertions verifying: - Override completion. - Zero realization retries. - A single final centered `ScrollTo` request. - `CenterMode` is not exposed to the `ScrollToRequested` observer. - No product code changes were made; this is a test-only stabilization fix. | Before | After | |----------|----------| | <img src="https://github.com/user-attachments/assets/7efcc482-86ea-4d96-bc6a-f00bd03000fa"> | <img src="https://github.com/user-attachments/assets/da5ded81-340e-4564-b585-168edc9af045"> |
kubaflo
pushed a commit
that referenced
this pull request
Oct 14, 2026
…e Device Test (#39217) ### Issue Details - The Windows device test `LoopedVisibleCollectionOverrideDoesNotEnterRealizationRetry` failed intermittently in #38782. - Failures occurred during high-physical-range setup or when validating that the pending override completed without entering the realization-retry path. ### Root Cause - The test assumed logical item `2` must be the **first visible physical item** after `ScrollIntoView()`. - The implementation under test, `IsCollectionCurrentItemOverrideVisible`, only requires the item to appear **anywhere within the visible range** (`FirstVisibleIndex` to `LastVisibleIndex`). - The test could continue while native scrolling, layout, and snap-point processing were still in progress. - The deferred override callback could therefore encounter an unready native state and schedule a realization retry. Diagnostics confirmed a failing run with `RetryCount = 1`. - Repeated successful runs after adding scroll-settling synchronization support a test setup/timing issue. ### Description of Change - Wrapped the initial native `ScrollIntoView()` operation in the existing `WaitForSettleAsync` helper to wait for terminal scroll events and a short quiet period. - Replaced the first-visible-item assumption with a predicate that scans the entire visible range for logical item `2` at a high physical index (`> 1000`). - Reused the predicate for both setup and final post-override validation. - Preserved the original assertions verifying: - Override completion. - Zero realization retries. - A single final centered `ScrollTo` request. - `CenterMode` is not exposed to the `ScrollToRequested` observer. - No product code changes were made; this is a test-only stabilization fix. | Before | After | |----------|----------| | <img src="https://github.com/user-attachments/assets/7efcc482-86ea-4d96-bc6a-f00bd03000fa"> | <img src="https://github.com/user-attachments/assets/da5ded81-340e-4564-b585-168edc9af045"> |
kubaflo
pushed a commit
that referenced
this pull request
Oct 18, 2026
…e Device Test (#39217) ### Issue Details - The Windows device test `LoopedVisibleCollectionOverrideDoesNotEnterRealizationRetry` failed intermittently in #38782. - Failures occurred during high-physical-range setup or when validating that the pending override completed without entering the realization-retry path. ### Root Cause - The test assumed logical item `2` must be the **first visible physical item** after `ScrollIntoView()`. - The implementation under test, `IsCollectionCurrentItemOverrideVisible`, only requires the item to appear **anywhere within the visible range** (`FirstVisibleIndex` to `LastVisibleIndex`). - The test could continue while native scrolling, layout, and snap-point processing were still in progress. - The deferred override callback could therefore encounter an unready native state and schedule a realization retry. Diagnostics confirmed a failing run with `RetryCount = 1`. - Repeated successful runs after adding scroll-settling synchronization support a test setup/timing issue. ### Description of Change - Wrapped the initial native `ScrollIntoView()` operation in the existing `WaitForSettleAsync` helper to wait for terminal scroll events and a short quiet period. - Replaced the first-visible-item assumption with a predicate that scans the entire visible range for logical item `2` at a high physical index (`> 1000`). - Reused the predicate for both setup and final post-override validation. - Preserved the original assertions verifying: - Override completion. - Zero realization retries. - A single final centered `ScrollTo` request. - `CenterMode` is not exposed to the `ScrollToRequested` observer. - No product code changes were made; this is a test-only stabilization fix. | Before | After | |----------|----------| | <img src="https://github.com/user-attachments/assets/7efcc482-86ea-4d96-bc6a-f00bd03000fa"> | <img src="https://github.com/user-attachments/assets/da5ded81-340e-4564-b585-168edc9af045"> |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Details
LoopedVisibleCollectionOverrideDoesNotEnterRealizationRetryfailed intermittently in September 22nd, Candidate — .NET 10 SR12 (10.0.120) #38782.Root Cause
2must be the first visible physical item afterScrollIntoView().IsCollectionCurrentItemOverrideVisible, only requires the item to appear anywhere within the visible range (FirstVisibleIndextoLastVisibleIndex).RetryCount = 1.Description of Change
ScrollIntoView()operation in the existingWaitForSettleAsynchelper to wait for terminal scroll events and a short quiet period.2at a high physical index (> 1000).ScrollTorequest.CenterModeis not exposed to theScrollToRequestedobserver.