Repository navigation
Use MVVM Toolkit partial properties in templates - #36074
Merged
jfversluis merged 1 commit intoJul 2, 2026
Merged
Conversation
Update the sample-content MAUI template to use CommunityToolkit.Mvvm 8.4.2 partial observable properties without enabling preview language features. Also switch the SQLitePCLRaw template dependency to bundle_e_sqlite3 3.0.3 so generated sample-content projects build without NuGet audit warnings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 36074Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 36074" |
This was referenced Jun 23, 2026
Contributor
Mac build validationThe PR description validates on Windows ( What I did: packed the template from this branch → installed into an isolated template hive → generated a
Confirmed on Mac:
Builds cleanly on macOS from a template-generation perspective. ℹ Note: I only exercised the build (no on-device run), and did not test |
kubaflo
approved these changes
Jul 1, 2026
This was referenced Jul 2, 2026
devanathan-vaithiyanathan
pushed a commit
to devanathan-vaithiyanathan/maui
that referenced
this pull request
Jul 7, 2026
<!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! - Updates the sample-content MAUI template to use `CommunityToolkit.Mvvm` 8.4.2. - Converts template page models from field-backed `[ObservableProperty]` members to partial observable properties without enabling preview language features. - Switches the sample-content SQLitePCLRaw dependency from `bundle_green` to `bundle_e_sqlite3` 3.0.3 and updates cgmanifest version mapping so generated projects avoid default NuGet audit warnings. - `dotnet build .\src\Templates\src\Microsoft.Maui.Templates.csproj -p:UpdateCgManifestBeforeBuild=false -p:GenerateCgManifest=false` - Packed templates and generated a `dotnet new maui --sample-content true` app from an isolated template hive. - `dotnet build <generated app> -f net10.0-windows10.0.19041.0 -p:RestoreIgnoreFailedSources=true` completed with 0 warnings and 0 errors, with no generated `LangVersion` or `EnablePreviewFeatures` entries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
devanathan-vaithiyanathan
pushed a commit
to devanathan-vaithiyanathan/maui
that referenced
this pull request
Jul 7, 2026
<!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! - Updates the sample-content MAUI template to use `CommunityToolkit.Mvvm` 8.4.2. - Converts template page models from field-backed `[ObservableProperty]` members to partial observable properties without enabling preview language features. - Switches the sample-content SQLitePCLRaw dependency from `bundle_green` to `bundle_e_sqlite3` 3.0.3 and updates cgmanifest version mapping so generated projects avoid default NuGet audit warnings. - `dotnet build .\src\Templates\src\Microsoft.Maui.Templates.csproj -p:UpdateCgManifestBeforeBuild=false -p:GenerateCgManifest=false` - Packed templates and generated a `dotnet new maui --sample-content true` app from an isolated template hive. - `dotnet build <generated app> -f net10.0-windows10.0.19041.0 -p:RestoreIgnoreFailedSources=true` completed with 0 warnings and 0 errors, with no generated `LangVersion` or `EnablePreviewFeatures` entries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
devanathan-vaithiyanathan
pushed a commit
to devanathan-vaithiyanathan/maui
that referenced
this pull request
Jul 8, 2026
<!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! - Updates the sample-content MAUI template to use `CommunityToolkit.Mvvm` 8.4.2. - Converts template page models from field-backed `[ObservableProperty]` members to partial observable properties without enabling preview language features. - Switches the sample-content SQLitePCLRaw dependency from `bundle_green` to `bundle_e_sqlite3` 3.0.3 and updates cgmanifest version mapping so generated projects avoid default NuGet audit warnings. - `dotnet build .\src\Templates\src\Microsoft.Maui.Templates.csproj -p:UpdateCgManifestBeforeBuild=false -p:GenerateCgManifest=false` - Packed templates and generated a `dotnet new maui --sample-content true` app from an isolated template hive. - `dotnet build <generated app> -f net10.0-windows10.0.19041.0 -p:RestoreIgnoreFailedSources=true` completed with 0 warnings and 0 errors, with no generated `LangVersion` or `EnablePreviewFeatures` entries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jul 14, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Summary
CommunityToolkit.Mvvm8.4.2.[ObservableProperty]members to partial observable properties without enabling preview language features.bundle_greentobundle_e_sqlite33.0.3 and updates cgmanifest version mapping so generated projects avoid default NuGet audit warnings.Validation
dotnet build .\src\Templates\src\Microsoft.Maui.Templates.csproj -p:UpdateCgManifestBeforeBuild=false -p:GenerateCgManifest=falsedotnet new maui --sample-content trueapp from an isolated template hive.dotnet build <generated app> -f net10.0-windows10.0.19041.0 -p:RestoreIgnoreFailedSources=truecompleted with 0 warnings and 0 errors, with no generatedLangVersionorEnablePreviewFeaturesentries.