Fix Android nested gesture ownership by AdamEssenmacher · Pull Request #35863 · dotnet/maui

AdamEssenmacher · 2026-06-10T20:43:59Z

Description of Change

This change fixes an Android gesture ownership regression introduced by the Issue7814 parent-scroll handoff behavior.

MauiRecyclerView now tracks when descendant content has requested touch ownership through Android’s RequestDisallowInterceptTouchEvent(true) contract. When a perpendicular gesture crosses touch slop, the recycler view still allows the Issue7814 parent handoff when no child has claimed the touch stream, but it no longer cancels the child path and forwards the gesture to the parent after descendant content has claimed ownership.

A regression test was added for a horizontal CarouselView containing a vertical CollectionView with a native-backed touch-claiming row. The test verifies that a horizontal drag across the claiming row completes with Up instead of Cancel, and that the parent CarouselView position does not change.

Issues Fixed

Fixes #35862

kubaflo · 2026-06-11T19:46:10Z

/review -b feature/enhanced-reviewer

MauiBot

Expert Review — 1 findings

See inline comments for details.

MauiBot · 2026-06-11T21:06:31Z

+			touchViewRect.Left + 20,
+			touchViewRect.Top + (touchViewRect.Height / 2));
+
+		var touchStatusAfterGesture = App.FindElement(TouchStatusLabelId).GetText();


[moderate] UI Test Reliability — This test reads the touch status and parent position immediately after the drag completes. Unlike the companion release test, it does not use RetryAssert, so Android/Appium timing can make the accessibility text or carousel position stale: a valid Up may not be observable yet, or a delayed parent handoff could be missed. Wrap the post-drag status/position assertions in App.RetryAssert so the test reliably verifies the final gesture state.

Addressed in ace6c96. I moved the post-drag reads and assertions into a single App.RetryAssert so the test waits for the settled state before checking both the Up status and the unchanged parent position together.

kubaflo · 2026-06-11T21:41:48Z

/review -b feature/enhanced-reviewer -p android

kubaflo

Could you please check the ai's suggestions?

kubaflo · 2026-06-13T15:20:11Z

/review -b feature/enhanced-reviewer -p android

MauiBot

Expert Review — 1 findings

See inline comments for details.

kubaflo · 2026-06-14T19:48:50Z

/review -b feature/enhanced-reviewer -p android

kubaflo · 2026-06-14T21:46:33Z

/review -b feature/enhanced-reviewer -p android

github-actions · 2026-06-30T22:15:48Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35863

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35863"

### Description of Change This change fixes an Android gesture ownership regression introduced by the Issue7814 parent-scroll handoff behavior. `MauiRecyclerView` now tracks when descendant content has requested touch ownership through Android’s `RequestDisallowInterceptTouchEvent(true)` contract. When a perpendicular gesture crosses touch slop, the recycler view still allows the Issue7814 parent handoff when no child has claimed the touch stream, but it no longer cancels the child path and forwards the gesture to the parent after descendant content has claimed ownership. A regression test was added for a horizontal `CarouselView` containing a vertical `CollectionView` with a native-backed touch-claiming row. The test verifies that a horizontal drag across the claiming row completes with `Up` instead of `Cancel`, and that the parent `CarouselView` position does not change. ### Issues Fixed Fixes #35862 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com>

github-actions Bot added area-controls-collectionview CollectionView, CarouselView, IndicatorView platform/android labels Jun 10, 2026

github-actions Bot mentioned this pull request Jun 11, 2026

[PR Review Queue] 2026-06-11 #35871

Closed

PureWeen force-pushed the inflight/current branch from 16dc4f5 to 7c04ed7 Compare June 11, 2026 17:13

AdamEssenmacher force-pushed the fix-issue7814-child-gesture branch from e4ae78c to 49aa398 Compare June 11, 2026 19:30

github-actions Bot added the s/agent-review-in-progress AI review is currently running for this PR label Jun 11, 2026

MauiBot reviewed Jun 11, 2026

View reviewed changes

MauiBot added s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) labels Jun 11, 2026

This comment was marked as outdated.

Sign in to view

MauiBot removed the s/agent-review-in-progress AI review is currently running for this PR label Jun 11, 2026

github-actions Bot added the s/agent-review-in-progress AI review is currently running for this PR label Jun 11, 2026

This comment was marked as outdated.

Sign in to view

MauiBot removed the s/agent-review-in-progress AI review is currently running for this PR label Jun 12, 2026

This was referenced Jun 12, 2026

[repo-status] .NET MAUI Daily Status - June 12, 2026 🌟 #35881

Closed

[PR Review Queue] 2026-06-12 #35888

Closed

kubaflo requested changes Jun 12, 2026

View reviewed changes

github-actions Bot added the s/agent-review-in-progress AI review is currently running for this PR label Jun 13, 2026

MauiBot reviewed Jun 13, 2026

View reviewed changes

Comment thread src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue7814.cs Resolved

This comment was marked as outdated.

Sign in to view

MauiBot removed the s/agent-review-in-progress AI review is currently running for this PR label Jun 13, 2026

github-actions Bot mentioned this pull request Jun 14, 2026

[repo-status] Daily Status — June 14, 2026 🌟 #35911

Closed

AdamEssenmacher force-pushed the fix-issue7814-child-gesture branch from 49aa398 to eaad81e Compare June 14, 2026 18:57

github-actions Bot added the s/agent-review-in-progress AI review is currently running for this PR label Jun 14, 2026

MauiBot removed the s/agent-review-in-progress AI review is currently running for this PR label Jun 14, 2026

This was referenced Jun 24, 2026

[PR Review Queue] 2026-06-24 #36098

Closed

[PR Review Queue] 2026-06-25 #36126

Closed

kubaflo force-pushed the inflight/current branch from 81295ab to 34a8f02 Compare June 25, 2026 20:02

This was referenced Jun 26, 2026

[PR Review Queue] 2026-06-26 #36151

Closed

[PR Review Queue] 2026-06-29 #36203

Closed

[PR Review Queue] 2026-06-30 #36229

Closed

kubaflo changed the base branch from inflight/current to main June 30, 2026 20:38

AdamEssenmacher added 3 commits July 1, 2026 00:14

Fix Android nested gesture ownership

6b9391f

Address nested gesture review feedback

1b3c506

Retry Issue7814 touch ownership assertion

d10da54

kubaflo force-pushed the fix-issue7814-child-gesture branch from ace6c96 to d10da54 Compare June 30, 2026 22:15

kubaflo changed the base branch from main to inflight/current June 30, 2026 22:15

kubaflo approved these changes Jun 30, 2026

View reviewed changes

kubaflo merged commit 072a19d into dotnet:inflight/current Jun 30, 2026
3 of 4 checks passed

github-actions Bot added this to the .NET 10 SR9 milestone Jun 30, 2026

github-actions Bot mentioned this pull request Jul 1, 2026

[repo-status] Daily Repo Status — July 1, 2026 #36262

Closed

kubaflo mentioned this pull request Jul 6, 2026

July 13th, Candidate #36411

Merged

github-actions Bot locked and limited conversation to collaborators Jul 31, 2026

github-actions Bot modified the milestones: .NET 10 SR9, .NET 10 SR10 Aug 20, 2026

Conversation

AdamEssenmacher commented Jun 10, 2026

Description of Change

Issues Fixed

Uh oh!

kubaflo commented Jun 11, 2026

Uh oh!

MauiBot left a comment

Choose a reason for hiding this comment

Expert Review — 1 findings

Uh oh!

MauiBot Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

AdamEssenmacher Jun 14, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

kubaflo commented Jun 11, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

kubaflo left a comment

Choose a reason for hiding this comment

Uh oh!

kubaflo commented Jun 13, 2026

Uh oh!

MauiBot left a comment

Choose a reason for hiding this comment

Expert Review — 1 findings

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

kubaflo commented Jun 14, 2026

Uh oh!

kubaflo commented Jun 14, 2026

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants