Skip to content

Fix the ref link for the DataFrameColumn.Info XML comments - #6192

Merged
michaelgsharp merged 1 commit into
dotnet:mainfrom
Spiria-Digital:Typo_DataFrameColumn_Info_method_Description
May 23, 2022
Merged

michaelgsharp merged 1 commit into
dotnet:mainfrom
Spiria-Digital:Typo_DataFrameColumn_Info_method_Description

Conversation

@mongeon

@mongeon mongeon commented May 10, 2022

Copy link
Copy Markdown
Contributor

Fix Typo under description #6136 as it's wasn't using the correct keywords based on others methods

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@ghost ghost added the community-contribution Pull requests submitted by community contributors label May 10, 2022
@mongeon
mongeon marked this pull request as ready for review May 10, 2022 14:02
@codecov

codecov Bot commented May 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #6192 (dc629bb) into main (4325125) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6192   +/-   ##
=======================================
  Coverage   68.35%   68.35%           
=======================================
  Files        1098     1098           
  Lines      242080   242080           
  Branches    25166    25166           
=======================================
+ Hits       165463   165469    +6     
+ Misses      70064    70058    -6     
  Partials     6553     6553           
Flag Coverage Δ
Debug 68.35% <ø> (+<0.01%) ⬆️
production 62.82% <ø> (+<0.01%) ⬆️
test 88.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.Data.Analysis/DataFrameColumn.cs 63.01% <ø> (ø)
src/Microsoft.ML.Maml/MAML.cs 25.38% <0.00%> (-1.53%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.23% <0.00%> (-0.15%) ⬇️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 86.87% <0.00%> (+1.13%) ⬆️
src/Microsoft.ML.FastTree/Training/StepSearch.cs 62.37% <0.00%> (+4.95%) ⬆️

@michaelgsharp
michaelgsharp merged commit a3003b0 into dotnet:main May 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Pull requests submitted by community contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants