Skip to content

Enabling different settings for the TextLoader on train and test data might lead to incorrect metrics with no error #5

Closed

Description

@GalOshri

The train and test data can be read with different TextLoaders, which makes it easy to introduce bugs. If there is a difference in the settings, the metrics are likely to be wrong but there are no errors.
Example:

string trainDataPath= "sentiment_data.tsv";
pipeline.Add(new TextLoader<SentimentData>(trainDataPath, useHeader: true));

// Later in the file, after completing the pipeline and training the model
string testDataPath = "sentiment_test.tsv";
var testData = new TextLoader<SentimentData>(testDataPath, userHeader: true, sep: ',');

var evaluator = new BinaryClassificationEvaluator();
BinaryClassificationMetrics metrics = evaluator.Evaluate(model, testData);

Evaluating on the test data will result in incorrect metrics as the test file will be parsed incorrectly. However, the experiment runs successfully with no errors, so this might be difficult to detect.

Activity

  1. added this to the 0518 milestone on May 9, 2018
  2. zeahmed commented on May 23, 2018

    @zeahmed
    Contributor

    Blocked by #216 and #119

  3. added a commit that references this issue on May 24, 2018
  4. removed this from the 0518 milestone on May 29, 2018
  5. added this to the 0718 milestone on Jun 27, 2018
  6. modified the milestones: 0718, 0818 on Aug 4, 2018
  7. removed this from the 0818 milestone on Aug 31, 2018
  8. abgoswam commented on Oct 15, 2018

    @abgoswam
    Member

    DRI RESPONSE: this is about legacy API, which we no longer support, no reason to continue to look into this one

  9. ghost locked as resolved and limited conversation to collaborators on Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions