Repository navigation
PipelineInference\RocketEngine bug fix for taking top k items. #262
Description
There is a bug in the RocketEngine GetTopLearners() method which potentially allows for duplicated pipelines to show up in the results. Bug found and diagnosed by @yaeldekel. Fix should be easy.
More detail: The logic in GetTopLearners() looped through two arrays, and compared the items in the second array to the items in the first, replacing them if some criterion was met (had higher weights). The way it was written could allow for a learner to replace more than one item in the first list, leading to two or more copies of the learner in our Top K array (which is a bug).
Activity
TomFinley commentedon May 30, 2018
I wonder if the nature of this bug could be added to the issue so I don't have to ask @yaeldekel . ;)
george-microsoft commentedon May 30, 2018
Bug description updated with a bit more detail.
added nuget sources in generated csproj (dotnet#262)
code migration from machinelearning-automl to machinelearning repo fe…
added nuget sources in generated csproj (dotnet#262)
Added onnx export functionality for LpNormNormalizingTransformer (#4161)
Added Onnx export functionality to PCATransformer (#4188)