Repository navigation
No Arguments in Entry Points #261
Description
The entry points for certain components are incorrectly designed. Normally components for entry-points are instantiated and their parameters are set on the object directly. For some reason, a handful of components slipped through, by having a separate "arguments" object be set, rather than have the arguments on the object directly.
The most conspicuous example of this flaw is the text loader.
machinelearning/src/Microsoft.ML/CSharpApi.cs
Line 1481 in 9f3076d
As we see in its usage here, we have the peculiar setup that we instantiate this, only to turn around and set a completely different object for its settings, which is completely wrong. Those parameters ought to be on the object itself.
machinelearning/test/Microsoft.ML.TestFramework/ModelHelper.cs
Lines 61 to 65 in 11d5ba7
This extends beyond text loader. As near as I can tell, all classes in CSharpApi.cs with the suffix "argument" in its name is an example of this anti-pattern.
Activity
TomFinley commentedon Nov 4, 2018
The C# API this issue treats on was marked legacy in #920, and we are now directly using components. Since this is no longer derived indirectly via entrypoints, my issue, while never having been solved, has ceased to be no relevant. Closing.
remove unused methods in consolehelper and nit picks in generated code (
code migration from machinelearning-automl to machinelearning repo fe…
remove unused methods in consolehelper and nit picks in generated code (
Added onnx export functionality for LpNormNormalizingTransformer (#4161)
Added Onnx export functionality to PCATransformer (#4188)