Repository navigation
Support ColumnAttribute on properties and not just fields #254
Description
It looks like it's been considered:
machinelearning/src/Microsoft.ML.Api/SchemaDefinition.cs
Lines 318 to 319 in ea07be8
I just wanted to get the issue started as it's probably the best solution to #180.
Reacted by FoggyFinder, Tobias Burger, Zeeshan Ahmed and Phillip Carter
Activity
zeahmed commentedon Jun 1, 2018
It could be a good feature to support custom transformation on some feature while using CollectionDataSource e.g. applying log on some numeric column(s).
isaacabraham commentedon Jun 7, 2018
Please can you also support not just properties but also non-default constructors? This is important to get a coherent F# story going.
dsyme commentedon Jul 30, 2018
I searched for uses of "GetFields" and here's what I see:
Relevant:
Not relevant:
dsyme commentedon Jul 31, 2018
@eerhardt I've taken a look at what it might take to fix this, could you take a look and check the general direction of travel please?
Here's the prototype: https://github.com/dsyme/machinelearning/compare/fs1...dsyme:fs2?expand=1
I've submitted a WIP PR for this though it is not yet complete: #616
eerhardt commentedon Jul 31, 2018
Taking a look now. /cc @Ivanidzo4ka as well, since he was investigating allowing properties too.
Zruty0 commentedon Aug 2, 2018
Now that #616 is in, I think this one should be closed.
I discovered one inconvenient side effect though: we are requiring both the getter and the setter to be present and public for the properties. It adds confusion to the cases like in #595 , where you can use properties to act like 'calculated columns', without a clear way to provide a setter.
I'll open a new issue for this.
CLI IFileInfo null exception fix (dotnet#254)
code migration from machinelearning-automl to machinelearning repo fe…
CLI IFileInfo null exception fix (dotnet#254)
Added onnx export functionality for LpNormNormalizingTransformer (#4161)
Added Onnx export functionality to PCATransformer (#4188)