Skip to content

Some functions are not used in HeaderSchema.cs #2069

Open

Description

@wschin

As title. In class

    [BestFriend]
    internal abstract class FeatureNameCollection : IEnumerable<string>

those functions

        private FeatureNameCollection()
        {
        }

        public static FeatureNameCollection Create(string[] names)
        {
            return Create(Utils.Size(names), names);
        }

        public static FeatureNameCollection Create(RoleMappedSchema schema)
        {
            …
        }

        public static void Save(ModelSaveContext ctx, in VBuffer<ReadOnlyMemory<char>> names)
        {
            …
        }

        public bool TryLookup(string name, out int index)
        {
            …
        }     

are not used.

Activity

  1. changed the title [-]Some functions are not tested in HeaderSchema.cs[/-] [+]Some functions are not used in HeaderSchema.cs[/+] on Jan 8, 2019
  2. Ivanidzo4ka commented on Jan 8, 2019

    @Ivanidzo4ka
    Contributor
    • @yaeldekel.
      This class still used in internal repository. I think it's fine to remove this class from this repository, as long as we move that class into internal repo.
  3. added
    Priority:3Work that is nice to have
    area-CoreCore ML.NET APIs and shared functionality
    enhancementNew feature or request
    and removed on Sep 8, 2026
  4. self-assigned this
    on Sep 9, 2026
  5. rosebyte commented on Sep 9, 2026

    @rosebyte
    Member

    triage: we will check it out

  6. added this to the ML.NET 7.0 milestone on Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Priority:3Work that is nice to havearea-CoreCore ML.NET APIs and shared functionalityenhancementNew feature or requestgreendevelopment

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions