Skip to content

Add performance tests for scenarios we care about #20

Closed

Description

@maryamariyan

From @KrzysztofCwalina on Apr 19, 2018, 2:41 PM PDT

No description provided.

Activity

  1. KrzysztofCwalina commented on May 9, 2018

    @KrzysztofCwalina
    Member
    1. We need to have a set of tests that contributors can run to verify that their PRs have desired impact on perf, i.e. they would run the tests on master, then on the branch with changes, and compare the results.
    2. This project is not to do comparative benchmarking between different ML frameworks.
  2. glebuk commented on May 10, 2018

    @glebuk
    Contributor

    Sounds good, then we should probably rename the project/file to PerfRegressionTest.
    Benchmarks are usually competitive.
    Hopefully, in this case the benchmarks can be normalized against hardware, so that if the run is on a different hw platform it will not fail. Alternatively it should track the perf and the hw platform it runs against.

  3. KrzysztofCwalina commented on May 10, 2018

    @KrzysztofCwalina
    Member

    Hopefully, in this case the benchmarks can be normalized against hardware, so that if the run is on a different hw platform it will not fail. Alternatively it should track the perf and the hw platform it runs against.

    The way we use such benchmarks is the following:

    1. Run the benchmark on master branch.
    2. Switch to PR branch
    3. Run the tests again.
    4. Post the diff in the PR description.

    This "isolates" the hardware.
    Having said that, the reports from BDN record information about the hardware, runtime, etc.

  4. shauheen commented on May 15, 2018

    @shauheen
    Contributor

    PR #62 merged this.

  5. added this to the 0518 milestone on May 15, 2018
  6. KrzysztofCwalina commented on May 15, 2018

    @KrzysztofCwalina
    Member

    The PR just merged an infrastructure project and a "demo" test. I think it would be good to add more real tests, e.g. flight delay prediction. I would be more than happy to add it, if we think this is the right representative test and we add the data set to the repo.

  7. ghost locked as resolved and limited conversation to collaborators on Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions