SysRandom.NextSigned() #169

Activity

1. TomFinley commented on May 16, 2018

   

   TomFinley

   on May 16, 2018

   Contributor

   More actions

   Oh that is nasty. Thanks @skyoxZ .

   Fortunately, at least in this codebase, it's used in exactly one place:
   

   machinelearning/src/Microsoft.ML.Data/Transforms/ShuffleTransform.cs

   Line 99 in c023727

   _forceShuffleSeed = args.ForceShuffleSeed ?? Host.Rand.NextSigned();

   
   That is, it derive a random seed for some other PRNG. If I think about how that class is used the effects will be limited, but we should definitely fix it.
2. shauheen

   added

   bugSomething isn't workingSomething isn't working

   on May 16, 2018
3. shauheen

   added this to the 0518 milestone on May 16, 2018
4. shauheen

   assigned

   Ivanidzo4ka

   on May 16, 2018
5. mikaelm12 commented on May 16, 2018

   

   mikaelm12

   on May 16, 2018

   More actions

   Seems like this issue has been resolved here: c5d168d
6. Ivanidzo4ka commented on May 16, 2018

   

   Ivanidzo4ka

   on May 16, 2018

   Contributor

   More actions

   Address in PR #172
7. Ivanidzo4ka

   closed this as completedon May 16, 2018
8. Dmitry-A

   added 2 commits that reference this issue on Apr 12, 2019

   rename 'AutoFitter' to 'Experiment' (dotnet#169)

   0d93e80

   code migration from machinelearning-automl to machinelearning repo fe…

   ...

   1702658
9. Dmitry-A

   added a commit that references this issue on Aug 22, 2019

   rename 'AutoFitter' to 'Experiment' (dotnet#169)

   2c1fd36
10. harishsk

    added 2 commits that reference this issue on Sep 6, 2019

    Added onnx export functionality for LpNormNormalizingTransformer (#4161)

    ...

    bc16b1d

    Added Onnx export functionality to PCATransformer (#4188)

    ...

    42e39b9
11. ghost locked as resolved and limited conversation to collaborators on Mar 30, 2022