You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So if we call it Baselines inside test folder, it would be first, and it would be easy to find as well!
Should we create issue to move baselines to test folder and rename them?
@justinormont I like your /test/BaselineOutput suggestion.
The intention of that directory is that it mirrors the TestOutput directory, produced by our tests. (In this way we can review any divergences between the expected output (in the baselines), and the actual output (as actually output by the test.
This however brings up what might be a larger (different?) issue. The test outputs used to be written just to the root directory, alongside ZBaselines. I might like them to be written to /test/TestOutput... that way, you get the two peer directories right next to each other.
Right now, as near as I can tell, the test output is not being written to a single directory, which makes tracking changes to baselines harder to find, and makes the practice of using diff tools to see all the test divergences at a glance now impossible (I have, for example, one TestOutput directory at Microsoft.ML.Core.Tests\netcoreapp2.0\TestOutput in my build, and another TestOutput directory at ``). Also it's being put in a very, very odd location: the bin directory right next to the test assemblies. I'm not sure the binary directory is really an appropriate location for test output.
I'm not sure why it was changed to this new system exactly, but we should revisit, maybe instead writing them to test/TestOutput, or something.
Activity
glebuk commentedon May 9, 2018
We should also consider moving the folder under /tests to make the purpose more obvious.
Ivanidzo4ka commentedon May 9, 2018
Does anyone remember why it's called ZBaselines instead of just baselines or TestBaselines?
costin-eseanu commentedon May 9, 2018
Because it would be sorted last in the folder view, so it's easy to find. :)
justinormont commentedon May 9, 2018
Agreed w / @glebuk & @Ivanidzo4ka (move+rename). Placing under /test/baselineOutput/ may be easier to understand its purpose.
Ivanidzo4ka commentedon May 9, 2018
So if we call it Baselines inside test folder, it would be first, and it would be easy to find as well!
Should we create issue to move baselines to test folder and rename them?
justinormont commentedon May 9, 2018
What do we think the best name for it is? Terse + understandable is my metric to optimize.
Also, welcome @costin-eseanu!
TomFinley commentedon May 10, 2018
@justinormont I like your
/test/BaselineOutputsuggestion.The intention of that directory is that it mirrors the
TestOutputdirectory, produced by our tests. (In this way we can review any divergences between the expected output (in the baselines), and the actual output (as actually output by the test.This however brings up what might be a larger (different?) issue. The test outputs used to be written just to the root directory, alongside
ZBaselines. I might like them to be written to/test/TestOutput... that way, you get the two peer directories right next to each other.Right now, as near as I can tell, the test output is not being written to a single directory, which makes tracking changes to baselines harder to find, and makes the practice of using diff tools to see all the test divergences at a glance now impossible (I have, for example, one
TestOutputdirectory atMicrosoft.ML.Core.Tests\netcoreapp2.0\TestOutputin my build, and anotherTestOutputdirectory at ``). Also it's being put in a very, very odd location: thebindirectory right next to the test assemblies. I'm not sure the binary directory is really an appropriate location for test output.I'm not sure why it was changed to this new system exactly, but we should revisit, maybe instead writing them to
test/TestOutput, or something.Also hi @costin-eseanu , you seem familiar somehow. :D
[-]Add a README.md to ZBaselines[/-][+]Add a README.md to `test/BaselineOutput`[/+]Ivanidzo4ka commentedon Oct 18, 2018
DRI RESPONSE: yes, we probably should. Basically this is folder where we keep baseline files for our tests.
Marking this as up-for-grabs.