Skip to content

Respect AutoAdvance for GetTimestamp in FakeTimeProvider - #5783

Merged
amadeuszl merged 3 commits into
dotnet:mainfrom
amadeuszl:alechniak/add-autoadvance-for-gettimestamp
Jan 10, 2025
Merged

amadeuszl merged 3 commits into
dotnet:mainfrom
amadeuszl:alechniak/add-autoadvance-for-gettimestamp

Conversation

@amadeuszl

@amadeuszl amadeuszl commented Jan 9, 2025 •

Copy link
Copy Markdown
Contributor

Resolves #5694

Microsoft Reviewers: Open in CodeFlow

@amadeuszl
amadeuszl requested a review from a team as a code owner January 9, 2025 09:19
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 84.76 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=911707&view=codecoverage-tab

@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 77.82 🔻

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=911946&view=codecoverage-tab

@amadeuszl
amadeuszl merged commit 045aaab into dotnet:main Jan 10, 2025
@amadeuszl
amadeuszl deleted the alechniak/add-autoadvance-for-gettimestamp branch January 10, 2025 08:15
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FakeTimeProvider does not advance when GetTimestamp is called

3 participants