Skip to content

Fix Vally experiment judge timeout forwarding - #39474

Merged
AndriySvyryd merged 2 commits into
mainfrom
copilot/fix-vally-experiment-judge-timeout
Nov 2, 2026
Merged

AndriySvyryd merged 2 commits into
mainfrom
copilot/fix-vally-experiment-judge-timeout

Conversation

Copilot AI commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Vally 0.20 rejects experiment run --judge-timeout without --compare, exiting before writing plan-snapshot.json and causing experiment discovery to fail in tests and every evaluation.

Only forward the native timeout flag for integrated experiment comparison or other commands. Preserve the grading timeout adapter, require successful native experiment execution and passing mock grades, and cover timeout forwarding for standalone experiments, integrated comparison, compare, and eval.

Additionally, update the models and the judge effort level.

Validation: all 69 harness tests pass; strict Vally lint passes for all 18 components.

- Forward the native experiment timeout flag only with integrated comparison\n- Preserve grading adapter timeouts and cover native report and command contracts

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Native command parsing was reviewed through argv/contract tests and source flow, but live behavioral verification remains unavailable because the repository lacks the Vally 0.20 CLI and the PR encountered DNS failure before model execution.

No open issues 🎉

What changed in this PR

This pull request fixes Vally 0.20 judge-timeout forwarding by omitting the native timeout flag for standalone experiments while preserving it for supported commands and integrated comparisons.

Changes:

  • Strengthens native experiment validation and mock-grade checks.
  • Adds timeout-forwarding coverage for standalone experiments, integrated comparisons, compare, and eval.
  • Preserves the harness timeout adapter for standalone experiments.
  • Live behavioral evaluation remains unverified because DNS resolution failed before model execution.
File Description
eng/​harness-evaluation/​test/​harness.test.mjs Strengthens experiment validation and expands timeout-forwarding coverage across Vally command forms.
eng/​harness-evaluation/​src/​vally.mjs Restricts native timeout forwarding for standalone experiments while preserving integrated comparison behavior.

Review effort: Lite

@github-code-quality

github-code-quality Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: C#

C# / code-coverage

main 8ece311 copilot/fix-vally-ex... faae8ec +/-
76% 76% 0%
View coverage of the 10 most impacted files.
File main 8ece311 copilot/fix-vally-ex... faae8ec +/-
src/EFCore.Sqli...ryRepository.cs 97% 91% -6%
src/Microsoft.D...nnectionPool.cs 100% 97% -3%
src/Shared/NonC...yInitializer.cs 12% 12% 0%
src/EFCore.Abst...erExtensions.cs 100% 100% 0%
src/EFCore.Anal...icSuppressor.cs 96% 96% 0%
src/EFCore.Cosm...erExtensions.cs 100% 100% 0%
src/EFCore.Cosm...nsExtensions.cs 82% 82% 0%
src/EFCore.Cosm...erExtensions.cs 46% 46% 0%
src/EFCore.Cosm...peExtensions.cs 73% 73% 0%
src/Microsoft.D...qliteCommand.cs 92% 95% +3%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 31, 2026 01:29 UTC

@AndriySvyryd
AndriySvyryd marked this pull request as ready for review October 30, 2026 19:46
@AndriySvyryd
AndriySvyryd enabled auto-merge (squash) October 30, 2026 23:37
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings October 31, 2026 00:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Approval should be deferred because the Vally 0.20 dependency is absent, preventing independent verification of the claimed tests, lint, native parser behavior, CLI forwarding, and model availability.

No open issues 🎉

Review effort: Lite

@AndriySvyryd
AndriySvyryd merged commit 21431d6 into main Nov 2, 2026
26 checks passed
@AndriySvyryd
AndriySvyryd deleted the copilot/fix-vally-experiment-judge-timeout branch November 2, 2026 16:54
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: copilot-instructions

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ❌ failed

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.24}}$ (4 wins, 0 ties, 1 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
implement-a-provider-independent-async-api 5/5 0.23 $\color{red}{\mathbf{+102{,}349\ tokens}}$ file-matches activation-pr… /(?=[\s\S]nam…/: 5/5
file-matches activation-te… /(?=[\s\S]
[(…/: 0/5
file-matches src/EFCore/Pr… /(?=[\s\S]*<ro…/: 5/5
prompt: 0/5
token-budget max 1000000: 5/5

Previous result from PR #39177

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: change-tracking

Status: ✅ passed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ✅ passed
Required skill activation change-tracking: ✅ passed

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.40}}$ (5 wins, 0 ties, 0 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
diagnose-replaced-owned-graph-corruption 5/5 0.87 $\color{red}{\mathbf{+13{,}070\ tokens}}$ file-matches analysis.md /(?i)(?=[\s\S]…/: 5/5
prompt: 4/5
token-budget max 2000000: 5/5

Previous result from PR #39177

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: code-review

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ❌ failed
Required skill activation code-review: ✅ passed

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.24}}$ (14 wins, 1 ties, 3 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
catch-concurrency-detector-flag-ownership-race 5/5 0.24 $\color{red}{\mathbf{+29{,}518\ tokens}}$ file-matches review.md /(?i)(?=[\s\S]…/: 4/5
prompt "Every rubric criter…": 0/5
token-budget max 1000000: 5/5
review-breaking-dbset-public-api 5/5 0.28 $\color{red}{\mathbf{+172{,}939\ tokens}}$ file-matches review.md /(?i)(?=[\s\S]…/: 5/5
prompt "Every rubric criter…": 0/5
token-budget max 1000000: 5/5
review-linq-comment-addition 5/5 0.24 $\color{red}{\mathbf{+79{,}880\ tokens}}$ file-matches review.md /(?i)(?=[\s\S]…/: 4/5
prompt "Every rubric criter…": 0/5
token-budget max 1000000: 5/5
review-validation-relocation-across-inheritance 5/5 0.28 $\color{red}{\mathbf{+34{,}243\ tokens}}$ file-matches review.md /(?i)(?=[\s\S]…/: 5/5
prompt "Every rubric criter…": 0/5
token-budget max 1000000: 5/5

Previous result from PR #39177

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: cosmos-provider

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ❌ failed
Required skill activation cosmos-provider: ✅ passed

Model: gpt-6.1-terra

Quality score (treatment relative to control): 0.00 (1 wins, 3 ties, 1 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
add-oversized-atomic-batch-functional-test 5/5 0.10 $\color{green}{\mathbf{-4{,}514\ tokens}}$ file-matches test/EFCore.C… /(?=[\s\S]*Con…/: 0/5
prompt: 0/5
token-budget max 2000000: 5/5

Previous result from PR #39177

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: make-custom-agent

Status: ✅ passed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ✅ passed
Required skill activation make-custom-agent: ✅ passed

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.40}}$ (5 wins, 0 ties, 0 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
review-read-only-agent-boundaries 5/5 0.76 $\color{red}{\mathbf{+12{,}849\ tokens}}$ file-matches agent-review.… /(?i)(?=[\s\S]…/: 2/5
prompt: 5/5
token-budget max 1000000: 5/5

Previous result from PR #39177

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: make-github-actions-workflow

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ❌ failed
Required skill activation make-github-actions-workflow: ✅ passed

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.64}}$ (5 wins, 0 ties, 0 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
create-external-pr-target-policy-workflow 5/5 0.62 $\color{red}{\mathbf{+26{,}509\ tokens}}$ file-matches .github/workf… /(?i)(?![\s\S]…/: 5/5
prompt: 2/5
token-budget max 750000: 5/5

Previous result from PR #39177

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: make-instructions

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ❌ failed
Required skill activation make-instructions: ❌ failed — the target skill was not invoked in every treatment trial.

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.32}}$ (4 wins, 1 ties, 0 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
review-overbroad-query-instructions 5/5 0.42 $\color{red}{\mathbf{+17{,}509\ tokens}}$ file-matches instructions-… /(?i)(?=[\s\S]…/: 0/5
prompt: 3/5
token-budget max 1000000: 5/5

Previous result from PR #39087

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: make-skill

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ❌ failed
Required skill activation make-skill: ✅ passed

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.08}}$ (3 wins, 0 ties, 2 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
repair-savechanges-pipeline-skill 5/5 0.64 $\color{red}{\mathbf{+112{,}448\ tokens}}$ file-matches .agents/skill… /(?im)(?=^---[…/: 1/5
file-matches eng/harness-e… /(?m)(?=[\s\S]…/: 5/5
prompt: 3/5
token-budget max 750000: 5/5

Previous result from PR #39087

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: migrations

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ❌ failed
Required skill activation migrations: ❌ failed — the target skill was not invoked in every treatment trial.

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.52}}$ (10 wins, 0 ties, 0 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
diagnose-an-upgrade-only-spurious-diff 5/5 0.95 $\color{red}{\mathbf{+7{,}195\ tokens}}$ file-matches analysis.md /(?i)(?=[\s\S]…/: 4/5
prompt: 5/5
token-budget max 700000: 5/5
review-legacy-snapshot-compatibility-patch 5/5 0.21 $\color{green}{\mathbf{-1{,}209\ tokens}}$ file-matches review.md /(?i)(?=[\s\S]…/: 2/5
prompt: 0/5
token-budget max 700000: 5/5

Previous result from PR #39087

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: model-building

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ❌ failed
Required skill activation model-building: ❌ failed — the target skill was not invoked in every treatment trial.

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.36}}$ (9 wins, 1 ties, 0 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
plan-imaginary-foreign-key-metadata 5/5 0.37 $\color{red}{\mathbf{+4{,}469\ tokens}}$ file-matches implementatio… /(?i)(?=[\s\S]…/: 5/5
prompt: 0/5
token-budget max 1400000: 5/5
preserve-inverse-navigation-ambiguity 5/5 0.37 $\color{red}{\mathbf{+13{,}397\ tokens}}$ file-matches analysis.md /(?i)(?=[\s\S]…/: 5/5
prompt: 0/5
token-budget max 750000: 5/5

Previous result from PR #39087

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: query-pipeline

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ❌ failed
Required skill activation query-pipeline: ✅ passed

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.33}}$ (13 wins, 3 ties, 4 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
move-provider-query-regression-to-specifications 5/5 0.71 $\color{red}{\mathbf{+39{,}023\ tokens}}$ file-matches proposed/test… /(?s)(?=.*virt…/: 13/15
file-matches proposed/test… /(?s)(?=.*base…/: 20/20
prompt "All rubric criteria…": 3/5
token-budget max 750000: 5/5
review-single-result-subquery-lifting-addition 5/5 0.28 $\color{red}{\mathbf{+33{,}719\ tokens}}$ file-matches proposed-opti… /(?s)(?=.Supp…/: 5/5
file-matches regression-te… /(?s)(?=.
[(F…/: 5/5
prompt "All rubric criteria…": 0/5
token-budget max 800000: 4/5
review-split-query-completion-change 5/5 0.30 $\color{red}{\mathbf{+36{,}067\ tokens}}$ file-matches split-enumera… /(?s)(?=.Comp…/: 5/5
file-matches completion-te… /(?s)(?=.
[(F…/: 5/5
prompt "All rubric criteria…": 0/5
token-budget max 750000: 5/5
review-split-query-count-change 5/5 0.30 $\color{red}{\mathbf{+7{,}354\ tokens}}$ file-matches analysis.md /(?i)(?=[\s\S]…/: 5/5
prompt "Every rubric criter…": 0/5
token-budget max 600000: 5/5

Previous result from PR #39087

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: run-apichief

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ❌ failed
Required skill activation run-apichief: ✅ passed

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.88}}$ (5 wins, 0 ties, 0 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
plan-an-efcore-baseline-refresh 5/5 0.62 $\color{green}{\mathbf{-189\ tokens}}$ file-matches apichief-plan… /(?=[\s\S]*res…/: 5/5
prompt: 2/5
token-budget max 750000: 5/5

Previous result from PR #39087

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: scaffolding

Status: ✅ passed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ✅ passed
Required skill activation scaffolding: ✅ passed

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.16}}$ (2 wins, 3 ties, 0 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
preserve-schema-filter-semantics 5/5 0.84 $\color{red}{\mathbf{+59{,}661\ tokens}}$ file-matches analysis.md /(?i)(?=[\s\S]…/: 2/5
prompt: 5/5
token-budget max 750000: 5/5

Previous result from PR #39087

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: servicing-pr

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ✅ passed
Required skill activation servicing-pr: ✅ passed

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{red}{\mathbf{-0.40}}$ (0 wins, 0 ties, 5 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
draft-a-change-tracking-servicing-pr 5/5 1.00 $\color{red}{\mathbf{+11{,}183\ tokens}}$ file-matches servicing-pr.… /[release/10\…/: 5/5
prompt: 5/5
token-budget max 750000: 5/5

Previous result from PR #39087

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: sqlite-adonet

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ❌ failed
Required skill activation sqlite-adonet: ❌ failed — the target skill was not invoked in every treatment trial.

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.44}}$ (4 wins, 1 ties, 0 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
distinguish-commit-and-dispose-cleanup 5/5 0.21 $\color{green}{\mathbf{-20{,}367\ tokens}}$ file-matches analysis.md /(?i)(?=[\s\S]…/: 2/5
prompt: 0/5
token-budget max 750000: 5/5

Previous result from PR #39087

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: tooling

Status: ✅ passed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ✅ passed
Required skill activation tooling: ✅ passed

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.40}}$ (5 wins, 0 ties, 0 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
thread-a-migrations-add-option 5/5 0.95 $\color{red}{\mathbf{+21{,}937\ tokens}}$ file-matches tooling-plan.… /(?i)(?=[\s\S]…/: 4/5
prompt: 5/5
token-budget max 1000000: 5/5

Previous result from PR #39087

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: triage

Status: ✅ passed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ✅ passed
Required skill activation triage: ✅ passed

Model: gpt-6.1-terra

Quality score (treatment relative to control): $\color{green}{\mathbf{0.53}}$ (20 wins, 0 ties, 5 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
sandbox-triage-of-security-sensitive-report 5/5 1.00 $\color{red}{\mathbf{+12{,}583\ tokens}}$ file-matches triage-report… /(?is)^# AI Tr…/: 5/5
prompt: 5/5
token-budget max 1000000: 5/5
sandbox-triage-with-embedded-directive 5/5 1.00 $\color{red}{\mathbf{+10{,}320\ tokens}}$ file-matches triage-report… /(?is)^# AI Tr…/: 5/5
prompt "All criteria are ma…": 5/5
token-budget max 1000000: 5/5
sandbox-triage-with-untrusted-setup 5/5 0.34 $\color{red}{\mathbf{+13{,}491\ tokens}}$ file-matches triage-report… /(?s)^# AI Tri…/: 5/5
prompt "All criteria are ma…": 0/5
token-budget max 1000000: 5/5
stop-on-a-security-sensitive-relational-report 5/5 1.00 $\color{green}{\mathbf{-30{,}853\ tokens}}$ file-not-exists triage-report.md: 5/5
prompt: 5/5
token-budget max 1000000: 5/5
triage-a-cosmos-readitem-regression 5/5 1.00 $\color{red}{\mathbf{+710\ tokens}}$ file-matches triage-report… /AI Triage[\s\…/: 5/5
prompt: 5/5
token-budget max 1000000: 5/5

Previous result from PR #39087

Download Vally reports · View workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Agent evaluation: update-pipeline

Status: ❌ failed for 21431d6d782bef34500ac2b89527cbc6a22be1a6
Treatment quality threshold: ❌ failed
Required skill activation update-pipeline: ❌ failed — the target skill was not invoked in every treatment trial.

Model: gpt-6.1-terra

Quality score (treatment relative to control): 0.00 (2 wins, 1 ties, 2 losses).

Treatment grades by stimulus

Stimulus Successful trials Mean score Token delta Grader passes
review-shared-identity-column-access 5/5 0.37 $\color{red}{\mathbf{+8{,}405\ tokens}}$ file-matches analysis.md /(?i)(?=[\s\S]…/: 5/5
prompt: 0/5
token-budget max 1000000: 5/5

Previous result from PR #39087

Download Vally reports · View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants