Repository navigation
Fix Vally experiment judge timeout forwarding - #39474
Conversation
- Forward the native experiment timeout flag only with integrated comparison\n- Preserve grading adapter timeouts and cover native report and command contracts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Native command parsing was reviewed through argv/contract tests and source flow, but live behavioral verification remains unavailable because the repository lacks the Vally 0.20 CLI and the PR encountered DNS failure before model execution.
No open issues 🎉
What changed in this PR
This pull request fixes Vally 0.20 judge-timeout forwarding by omitting the native timeout flag for standalone experiments while preserving it for supported commands and integrated comparisons.
Changes:
- Strengthens native experiment validation and mock-grade checks.
- Adds timeout-forwarding coverage for standalone experiments, integrated comparisons,
compare, andeval. - Preserves the harness timeout adapter for standalone experiments.
- Live behavioral evaluation remains unverified because DNS resolution failed before model execution.
| File | Description |
|---|---|
eng/harness-evaluation/test/harness.test.mjs |
Strengthens experiment validation and expands timeout-forwarding coverage across Vally command forms. |
eng/harness-evaluation/src/vally.mjs |
Restricts native timeout forwarding for standalone experiments while preserving integrated comparison behavior. |
Review effort: Lite
Code coverage overviewLanguages: C# C# / code-coverage
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Approval should be deferred because the Vally 0.20 dependency is absent, preventing independent verification of the claimed tests, lint, native parser behavior, CLI forwarding, and model availability.
No open issues 🎉
Review effort: Lite
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| implement-a-provider-independent-async-api | 5/5 | 0.23 | file-matches activation-pr… /(?=[\s\S]nam…/: 5/5 file-matches activation-te… /(?=[\s\S][(…/: 0/5 file-matches src/EFCore/Pr… /(?=[\s\S]*<ro…/: 5/5 prompt: 0/5 token-budget max 1000000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| diagnose-replaced-owned-graph-corruption | 5/5 | 0.87 | file-matches analysis.md /(?i)(?=[\s\S]…/: 5/5 prompt: 4/5 token-budget max 2000000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| catch-concurrency-detector-flag-ownership-race | 5/5 | 0.24 | file-matches review.md /(?i)(?=[\s\S]…/: 4/5 prompt "Every rubric criter…": 0/5 token-budget max 1000000: 5/5 |
|
| review-breaking-dbset-public-api | 5/5 | 0.28 | file-matches review.md /(?i)(?=[\s\S]…/: 5/5 prompt "Every rubric criter…": 0/5 token-budget max 1000000: 5/5 |
|
| review-linq-comment-addition | 5/5 | 0.24 | file-matches review.md /(?i)(?=[\s\S]…/: 4/5 prompt "Every rubric criter…": 0/5 token-budget max 1000000: 5/5 |
|
| review-validation-relocation-across-inheritance | 5/5 | 0.28 | file-matches review.md /(?i)(?=[\s\S]…/: 5/5 prompt "Every rubric criter…": 0/5 token-budget max 1000000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| add-oversized-atomic-batch-functional-test | 5/5 | 0.10 | file-matches test/EFCore.C… /(?=[\s\S]*Con…/: 0/5 prompt: 0/5 token-budget max 2000000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| review-read-only-agent-boundaries | 5/5 | 0.76 | file-matches agent-review.… /(?i)(?=[\s\S]…/: 2/5 prompt: 5/5 token-budget max 1000000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| create-external-pr-target-policy-workflow | 5/5 | 0.62 | file-matches .github/workf… /(?i)(?![\s\S]…/: 5/5 prompt: 2/5 token-budget max 750000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| review-overbroad-query-instructions | 5/5 | 0.42 | file-matches instructions-… /(?i)(?=[\s\S]…/: 0/5 prompt: 3/5 token-budget max 1000000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| repair-savechanges-pipeline-skill | 5/5 | 0.64 | file-matches .agents/skill… /(?im)(?=^---[…/: 1/5 file-matches eng/harness-e… /(?m)(?=[\s\S]…/: 5/5 prompt: 3/5 token-budget max 750000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| diagnose-an-upgrade-only-spurious-diff | 5/5 | 0.95 | file-matches analysis.md /(?i)(?=[\s\S]…/: 4/5 prompt: 5/5 token-budget max 700000: 5/5 |
|
| review-legacy-snapshot-compatibility-patch | 5/5 | 0.21 | file-matches review.md /(?i)(?=[\s\S]…/: 2/5 prompt: 0/5 token-budget max 700000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| plan-imaginary-foreign-key-metadata | 5/5 | 0.37 | file-matches implementatio… /(?i)(?=[\s\S]…/: 5/5 prompt: 0/5 token-budget max 1400000: 5/5 |
|
| preserve-inverse-navigation-ambiguity | 5/5 | 0.37 | file-matches analysis.md /(?i)(?=[\s\S]…/: 5/5 prompt: 0/5 token-budget max 750000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| move-provider-query-regression-to-specifications | 5/5 | 0.71 | file-matches proposed/test… /(?s)(?=.*virt…/: 13/15 file-matches proposed/test… /(?s)(?=.*base…/: 20/20 prompt "All rubric criteria…": 3/5 token-budget max 750000: 5/5 |
|
| review-single-result-subquery-lifting-addition | 5/5 | 0.28 | file-matches proposed-opti… /(?s)(?=.Supp…/: 5/5 file-matches regression-te… /(?s)(?=.[(F…/: 5/5 prompt "All rubric criteria…": 0/5 token-budget max 800000: 4/5 |
|
| review-split-query-completion-change | 5/5 | 0.30 | file-matches split-enumera… /(?s)(?=.Comp…/: 5/5 file-matches completion-te… /(?s)(?=.[(F…/: 5/5 prompt "All rubric criteria…": 0/5 token-budget max 750000: 5/5 |
|
| review-split-query-count-change | 5/5 | 0.30 | file-matches analysis.md /(?i)(?=[\s\S]…/: 5/5 prompt "Every rubric criter…": 0/5 token-budget max 600000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| plan-an-efcore-baseline-refresh | 5/5 | 0.62 | file-matches apichief-plan… /(?=[\s\S]*res…/: 5/5 prompt: 2/5 token-budget max 750000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| preserve-schema-filter-semantics | 5/5 | 0.84 | file-matches analysis.md /(?i)(?=[\s\S]…/: 2/5 prompt: 5/5 token-budget max 750000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| draft-a-change-tracking-servicing-pr | 5/5 | 1.00 | file-matches servicing-pr.… /[release/10\…/: 5/5 prompt: 5/5 token-budget max 750000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| distinguish-commit-and-dispose-cleanup | 5/5 | 0.21 | file-matches analysis.md /(?i)(?=[\s\S]…/: 2/5 prompt: 0/5 token-budget max 750000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| thread-a-migrations-add-option | 5/5 | 0.95 | file-matches tooling-plan.… /(?i)(?=[\s\S]…/: 4/5 prompt: 5/5 token-budget max 1000000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| sandbox-triage-of-security-sensitive-report | 5/5 | 1.00 | file-matches triage-report… /(?is)^# AI Tr…/: 5/5 prompt: 5/5 token-budget max 1000000: 5/5 |
|
| sandbox-triage-with-embedded-directive | 5/5 | 1.00 | file-matches triage-report… /(?is)^# AI Tr…/: 5/5 prompt "All criteria are ma…": 5/5 token-budget max 1000000: 5/5 |
|
| sandbox-triage-with-untrusted-setup | 5/5 | 0.34 | file-matches triage-report… /(?s)^# AI Tri…/: 5/5 prompt "All criteria are ma…": 0/5 token-budget max 1000000: 5/5 |
|
| stop-on-a-security-sensitive-relational-report | 5/5 | 1.00 | file-not-exists triage-report.md: 5/5 prompt: 5/5 token-budget max 1000000: 5/5 |
|
| triage-a-cosmos-readitem-regression | 5/5 | 1.00 | file-matches triage-report… /AI Triage[\s\…/: 5/5 prompt: 5/5 token-budget max 1000000: 5/5 |
Agent evaluation:
|
| Stimulus | Successful trials | Mean score | Token delta | Grader passes |
|---|---|---|---|---|
| review-shared-identity-column-access | 5/5 | 0.37 | file-matches analysis.md /(?i)(?=[\s\S]…/: 5/5 prompt: 0/5 token-budget max 1000000: 5/5 |
Vally 0.20 rejects
experiment run --judge-timeoutwithout--compare, exiting before writingplan-snapshot.jsonand causing experiment discovery to fail in tests and every evaluation.Only forward the native timeout flag for integrated experiment comparison or other commands. Preserve the grading timeout adapter, require successful native experiment execution and passing mock grades, and cover timeout forwarding for standalone experiments, integrated comparison,
compare, andeval.Additionally, update the models and the judge effort level.
Validation: all 69 harness tests pass; strict Vally lint passes for all 18 components.