Repository navigation
Performance decrease (10 second delay) in database migration 8.0.0 vs 8.0.3 #33399
Description
Hi,
After upgrading from 8.0.0 to 8.0.3, get a large performance decrease during database creation.
https://github.com/EvgenyMuryshkin/EF8PPerf
EF 9 also has the same issue
Include provider and version information
.NET 8/.NET 9
EF 8.0.0 => 8.0.3, 9.0.0-preview.2.24128.4
Windows 11 Pro
VS 2022 17.9.4/17.10.0 Preview 2.0
Thank you
Reacted by Sveinung, Michael Conrad, Fabien Ménager and Khalid Abuhakmeh
Activity
roji commentedon Mar 26, 2024
@EvgenyMuryshkin looks like a duplicate of #33176, which has already been fixed for 8.0.4. Can you please try the workaround in this comment and confirm?
EvgenyMuryshkin commentedon Mar 26, 2024
@roji nope, did not work.
I think my issue is not model creation, but database creation.
Model is already created
roji commentedon Mar 26, 2024
This doesn't repro for me (MacOS Sonoma):
I'm noticing that EF upgraded patch versions of SqlClient between 8.0.0 (SqlClient 5.1.1) and 8.0.3 (SqlClient 5.1.5). Can you try to take a dependency on SqlClient 5.1.1 when using EF Core 8.0.0 to see if the problem comes form there? I'm thinking possibly of #7283 or similar.
EvgenyMuryshkin commentedon Mar 26, 2024
@roji EF 8.0.1 fast, 8.0.2 slow.
with 8.0.0
5.1.1 - fast
5.1.2 - slow
roji commentedon Mar 26, 2024
Thanks for confirming!
The 5.1.2 release notes are here, the culprit may be dotnet/SqlClient#1983. This may very well be a dup of #7283.
/cc @David-Engel @cheenamalhotra
cheenamalhotra commentedon Mar 27, 2024
Have you tried setting ConnectRetryCount=0 on the connection string to disable transient fault handling?
ajcvickers commentedon Mar 27, 2024
@cheenamalhotra This should not be needed. Issue #7283 goes into this in detail.
ajcvickers commentedon Mar 27, 2024
/cc @SamMonoRT
roji commentedon Mar 27, 2024
@cheenamalhotra in addition to #7283, see dotnet/SqlClient#29 and dotnet/SqlClient#463 on the SqlClient side where this was discussed at length (especially why the connection string-based approach is insufficient here).
EvgenyMuryshkin commentedon Mar 27, 2024
it actually worked, thanks :)
for 8.0.3 and 9.0.0 as well
42 remaining items
ajcvickers commentedon Aug 29, 2024
Note: this is now fixed for 9.0 RC2 with an LTS SqlClient by changing to SqlClient 5.1.6. We plan to also patch 8.0 for this, but we're going to let 5.1.6 have a bit of time in the wild first.
AndriySvyryd commentedon Oct 8, 2024
Fixed in 576f0d0