Contains fallback translation fails when the array parameter has AsQueryable

In the legacy translation mode for Contains with an array parameter source (e.g. for old SQL Server), our pattern matching fails when the parameter source is wrapped by AsQueryable. For normal cases, AsQueryable is removed by nav expansion as it's unnecessary (ParameterQueryRootExpression is already queryable); but there are certain cases where nav expansion does not visit (e.g. nested Contains, see #32217 for the full details).

As a workaround suitable for patching 8.0, we can simply recognize and unwrap AsQueryable in the Contains fallback logic.

Visit arguments in QueryableMethodNormalizingExpressionVisitor after …

@ajcvickers

@ajcvickers this got fixed by the same PR (#32219) as #32215; I fixed both in a single PR since fixing #32215 caused failures requiring this issue to be fixed as well.

@roji

@roji Sounds good. Let's leave them both open for now, and then close them both if/when the single PR is approved and merged for servicing.

Visit arguments in QueryableMethodNormalizingExpressionVisitor after …

Navigation Menu

Repository navigation

Contains fallback translation fails when the array parameter has AsQueryable #32218

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Contains fallback translation fails when the array parameter has AsQueryable #32218

Description

Activity

roji commented on Nov 9, 2023

ajcvickers commented on Nov 9, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions