Repository navigation
Fix SOS Helix private-runtime overlay to use the runtime product version - #6143
Merged
steveisok merged 1 commit intoOct 23, 2026
Merged
Conversation
The SOS Helix launcher overlays LiveRuntimeDir onto shared/Microsoft.NETCore.App/<runtime-version>, but HelixPayload.targets passed RuntimeDownload (build version, 11.0.0-rtm.26514.118). Helix installs the runtime under its product version (11.0.0, the Runtime metadata), so since stabilized .NET 11 versions arrived in dotnet#6136 every private-runtime SOS work item exits 3 before running tests. Keep downloading by RuntimeDownload but pass Runtime as --runtime-version. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9525fb2-c2dd-4524-8de0-24a2d0b0f6a7
max-charlamb
approved these changes
Oct 23, 2026
3 tasks
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SOS Helix legs of dotnet/runtime's
runtime-diagnosticspipeline are blocked. Every SOS work item fails before any test runs. This affects all runtime PRs since roughly 2026-10-23 16:00 UTC. Example: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1646832 (dotnet/runtime#136362). Each work item exits 3 with:Root cause
For private runtime testing (
PrivateBuildTesting=true+LiveRuntimeDir),src/tests/SOS.Tests/HelixPayload.targetspasses--runtime-version "%(RuntimeDownload)"toruntests.sh/runtests.cmd. They use that value as theshared/Microsoft.NETCore.App/<version>folder to overlay the private runtime onto.RuntimeDownload(MicrosoftNETCorePlatformsVersion) is the build/download version. The installed folder, however, is named after the product version (Runtime=MicrosoftNETCoreAppRefVersion). These two values were identical until #6136 moved .NET 11 to stabilized RTM versioning, so the bug went unnoticed:RuntimeDownload11.0.0-rtm.26480.11311.0.0-rtm.26514.118Runtime11.0.0-rtm.26480.11311.0.0How the folder gets its name: the Helix SDK's
AddAdditionalRuntimestarget (tools/dotnet-cli/DotNetCli.targets) resolves the archive withFindDotNetCliPackageand extracts it intodotnet-cliwithout changing its layout. The resolved archive,ci.dot.net/public/Runtime/11.0.0-rtm.26514.118/dotnet-runtime-11.0.0-linux-x64.tar.gz(itsproductVersion.txtis11.0.0), containsshared/Microsoft.NETCore.App/11.0.0/.Fix
RuntimeDownload(RequiredRuntimeVersionsis unchanged), but pass%(HelixWorkItem.Runtime)as--runtime-version.Runtimemetadata.I checked the other places that use these versions and they need no change: the SOS harness metadata, CommonTestRunner and DbgShim already configure by
Runtime, the managed Helix projects use the stableTestHostRuntimeVersion, and macOS picks--fx-versionfromdotnet --list-runtimes.Validation
CreateHelixPayloadthrough a scratch MSBuild project that importseng/Version.Details.props,eng/Versions.propsandSOS.Tests/HelixPayload.targets, with payload staging stubbed out:--runtime-version "11.0.0-rtm.26514.118"; after:--runtime-version "11.0.0".RequiredRuntimeVersionsstays10.0.10;11.0.0-rtm.26514.118.runtests.cmd) — after:--runtime-version "11.0.0".Runtime— the new error is raised.runtests.shagainst a fake correlation payload that copies the real archive layout (shared/Microsoft.NETCore.App/11.0.0). With the old value it reproduces the exact CI error. With the new value it overlays the runtime and continues.