Repository navigation
Enable SOS Helix tests in internal builds - #6049
Merged
max-charlamb merged 3 commits intoSep 21, 2026
Merged
Conversation
Add internal queue aliases and use a shared cross-platform Helix submission step so SOS tests can run in both public and internal pipelines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fef3d44c-e682-4eee-9fcf-f621dda46b83
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Resolve the missing Helix access token configuration for SOS jobs and internal pull-request builds.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Enables SOS Helix tests in internal pipelines with internal queues, credential routing, and shared Windows/Unix submission logic.
Changes:
- Adds internal Helix queue aliases.
- Runs SOS Helix jobs in internal builds.
- Shares platform-specific MSBuild invocation.
File summaries
| File | Summary |
|---|---|
eng/pipelines/sos-helix.yml |
Selects public or internal queues and invokes shared submission steps. Critical token configuration issue remains. |
eng/pipelines/send-to-helix-step.yml |
Shares Windows and Unix MSBuild submission logic. |
eng/pipelines/helix-platforms.yml |
Defines internal Helix queue aliases. |
diagnostics.yml |
Enables SOS Helix jobs across configured platforms. Moderate issue remains for internal pull-request token access. |
Review details
Suppressed comments (1)
diagnostics.yml:132
- This unconditional matrix now creates SOS Helix jobs for internal pull-request builds, but the
DotNet-HelixApi-Accessvariable group is excluded wheneverBuild.ReasonisPullRequest(eng/common/core-templates/job/job.yml:112-114). Those jobs therefore select the internal queues here without a usableHelixAccessTokenand will fail to submit; keep this matrix out of internal PR builds or provide a token-safe PR configuration.
- template: /eng/pipelines/platform-matrix.yml
parameters:
jobTemplate: /eng/pipelines/sos-helix.yml
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Opt the SOS Helix jobs into Arcade telemetry infrastructure so official internal builds import the DotNet-HelixApi-Access variable group. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fef3d44c-e682-4eee-9fcf-f621dda46b83
steveisok
approved these changes
Sep 21, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fef3d44c-e682-4eee-9fcf-f621dda46b83
steveisok
approved these changes
Sep 21, 2026
max-charlamb
enabled auto-merge (squash)
September 21, 2026 16:35
Member
Author
|
/ba-g flaky run |
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation