Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Enable building and running ILVerification tests by default - #6307

Merged
jkotas merged 1 commit into
dotnet:masterfrom
jkotas:ILVerificationTests
Sep 7, 2018
Merged

jkotas merged 1 commit into
dotnet:masterfrom
jkotas:ILVerificationTests

Conversation

@jkotas

@jkotas jkotas commented Sep 7, 2018

Copy link
Copy Markdown
Member

No description provided.

@@ -0,0 +1,3 @@
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="ILTests.targets" />

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be possible to avoid these boilerplate .ilproj files by writing msbuild traversal rule. I have opted for the boilerplate files since there is not that many of them and they are much easier to understand than msbuild traversal rules.

@jcouv

jcouv commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

Fantastic. Thanks a lot for taking care of this!

@jcouv jcouv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@jkotas
jkotas merged commit 572f4e6 into dotnet:master Sep 7, 2018
@jkotas
jkotas deleted the ILVerificationTests branch September 7, 2018 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants