Skip to content

Replace CompletionDelegate with Action<CompletionContext> #1927

Closed

Description

@jonsequitur
namespace System.CommandLine.Completions
{
    // This is syntactically the same as Action<CompletionContext>, so adding a new delegate type is discouraged.
    // Unless you think you need the type to exists as a place to put documentation.
    public delegate IEnumerable<CompletionItem> CompletionDelegate(CompletionContext context);

Activity

  1. KalleOlaviNiemitalo commented on Nov 2, 2022

    @KalleOlaviNiemitalo

    CompletionDelegate does not return void in the public source. Is it different in the API proposal that was reviewed?

    public delegate IEnumerable<CompletionItem> CompletionDelegate(CompletionContext context);

  2. jonsequitur commented on Nov 2, 2022

    @jonsequitur
    ContributorAuthor

    This might be a bug in the API summarizer. I'll take a look.

    This was a handmade error.

  3. self-assigned this
    on Nov 3, 2022
  4. added 2 commits that reference this issue on Nov 3, 2022
    93203d3
    f99bf0f
  5. added this to the 2.0 GA milestone on Nov 9, 2022
  6. added a commit that references this issue on Jan 28, 2024
    466d165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions