Repository navigation
[release/8.0] Fix pRequestInfo INVALID_POINTER_READ caused by GCs - #50459
Merged
Merged
Conversation
|
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
Member
|
@Tratcher can you get an approval on this? I can merge/enable auto-merge after that |
Member
|
This was approved by tactics, but @adityamandaleeka can sign off locally. |
Tratcher
approved these changes
Aug 31, 2023
wtgodbe
enabled auto-merge (squash)
August 31, 2023 18:30
Member
|
Yup, approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix pRequestInfo INVALID_POINTER_READ caused by GCs
Backport of #50446 to release/8.0
Description
When using the IHttpSysRequestInfoFeature it's possible to hit invalid pointer read errors which causes a process crash. It's also possible to hit other issue caused by the invalid pointer. The error occurs when a GC moves to memory of the request's _backingBuffer before trying to access the RequestInfo property of IHttpSysRequestInfoFeature.
The fix is to adjust the pRequestInfo pointer similar to how other pointers in this class are adjusted.
Fixes #50445
Customer Impact
It's not possible to use the IHttpSysRequestInfoFeature without eventually crashing the process due to the INVALID_POINTER_READ.
Regression?
Risk
The change is very small an in-line with how pointers are used/updated within NativeRequestContext.
Verification
I haven't been able to reproduce the crash locally, but I was able to confirm this is the root caused from a crash dump. I did verify this change did not regress this feature.
Packaging changes reviewed?
When servicing release/2.1