Separate MessagePackHubProtocol into its own package by wtgodbe · Pull Request #25253 · dotnet/aspnetcore

wtgodbe · 2020-08-25T20:55:43Z

Resolves #25087

Internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=795545&view=results

Todo - update this https://github.com/dotnet/aspnetcore-internal/blob/master/docs/release/ReleaseActivities.md#step-0-before-the-release, and this https://github.com/dotnet/aspnetcore-internal/blob/master/docs/release/ReleaseActivities.md#what-gets-published

BrennanConroy · 2020-08-26T04:03:42Z

Don't you need a separate .javaproj and dependencies file etc.?

wtgodbe · 2020-08-26T16:19:03Z

@BrennanConroy @halter73 is the goal to get two separate .jars, or two separate packages within the signalr .jar we already produce? Still trying to figure out how to do the second, if that's what we need (this does the first)

wtgodbe · 2020-08-26T16:21:38Z

Don't you need a separate .javaproj and dependencies file etc.?

The only .javaproj in the folder is signalr.client.java.Tests.javaproj, for the tests. I had assumed we defined the signalr.jar build in build.gradle

BrennanConroy · 2020-08-26T16:27:42Z

signalr.client.java.Tests.javaproj, for the tests

That's a small hack, it's actually for tests and the package.

the goal to get two separate .jars

This.

wtgodbe · 2020-08-31T17:24:15Z

New internal build: https://dev.azure.com/dnceng/public/_build/results?buildId=795120&view=results

@BrennanConroy @halter73 PTAL

wtgodbe · 2020-08-31T17:35:56Z

@Pilchie asking for this to go in for rc1 - it separates MessagePack into its own package, matching what we do in the C# & TypeScript clients. Also allows us to remove unneeded dependencies from each package

ghost · 2020-08-31T17:52:05Z

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

sebastienros · 2020-08-31T23:02:32Z

@wtgodbe haven't looked at it at all yet

BrennanConroy

We can figure out the VSCode test stuff later

Pilchie · 2020-09-01T00:19:08Z

Well, I'd rather get this in RC1 than later, so...

Approved for RC1 pending CI completion if merged before 10am Pacific on 2020-09-01.

halter73 · 2020-09-01T02:37:07Z

+dependencies {
+    implementation project(':core')
+    compile 'org.msgpack:msgpack-core:0.8.20'
+    compile 'org.msgpack:jackson-dataformat-msgpack:0.8.20'


When I try using compile in build.gradle it warns "compile is deprecated; replace with implementation"

What command did you run to produce that warning? I don't see it locally w/ compileJava or createPackage

I saw this in Android Studio

ghost · 2020-09-01T17:08:42Z

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

Pilchie · 2020-09-01T17:09:13Z

Removed approval since the deadline passed. Please update the shiproom template for it.

jamshedd · 2020-09-01T18:05:40Z

Approved for RC1.

jamshedd · 2020-09-01T18:06:27Z

Approved for RC1.

wtgodbe · 2020-09-01T20:26:22Z

Follow-up issues: #25510 #25511 #25512

ghost added the area-signalr Includes: SignalR clients and servers label Aug 25, 2020

wtgodbe added this to the 5.0.0-rc1 milestone Aug 28, 2020

wtgodbe requested review from BrennanConroy and halter73 August 31, 2020 17:12

wtgodbe force-pushed the wtgodbe/MessagePackage branch from 10f4772 to 3de4db5 Compare August 31, 2020 17:19

wtgodbe added 11 commits August 31, 2020 10:20

Separate MessagePackHubProtocol into its own package

c466885

Remove gitignore

a429195

Maybe undo this later

5b9b455

More factoring

94f271b

Get gradle test working

2c767b3

Get gradle test working

3b19444

Get rid of version.java

c2d6ab7

Separate build.gradle files for all

4c7c9af

Create separate javaproj's for everything

d04fb5c

Fix warnings

0f2c93b

Resolve conflicts

b9244b8

wtgodbe force-pushed the wtgodbe/MessagePackage branch from 3de4db5 to b9244b8 Compare August 31, 2020 17:22

wtgodbe marked this pull request as ready for review August 31, 2020 17:22

Fixup gitignore

b167b29

wtgodbe added ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. Servicing-consider Shiproom approval is required for the issue labels Aug 31, 2020

BrennanConroy reviewed Aug 31, 2020

View reviewed changes

Comment thread .../clients/java/signalr/core/src/main/java/com/microsoft/signalr/HttpHubConnectionBuilder.java Resolved

Comment thread src/SignalR/clients/java/signalr/core/signalr.client.java.core.javaproj Resolved

Comment thread src/SignalR/clients/java/signalr/.gitignore Resolved

Feedback, fix error

178b8da

Fix folder structure

18f368c

BrennanConroy approved these changes Aug 31, 2020

View reviewed changes

Pilchie added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Sep 1, 2020

halter73 reviewed Sep 1, 2020

View reviewed changes

Comment thread src/SignalR/clients/java/signalr/.gitignore Resolved

halter73 reviewed Sep 1, 2020

View reviewed changes

BrennanConroy reviewed Sep 1, 2020

View reviewed changes

Comment thread src/SignalR/clients/java/signalr/test/signalr.client.java.Tests.javaproj Resolved

Skip helix tests, fix .gitignore

7a3ca89

Pilchie added Servicing-consider Shiproom approval is required for the issue and removed Servicing-approved Shiproom has approved the issue labels Sep 1, 2020

jamshedd added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Sep 1, 2020

halter73 approved these changes Sep 1, 2020

View reviewed changes

halter73 reviewed Sep 1, 2020

View reviewed changes

Comment thread src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/TransferFormat.java Resolved

Make TransferFormat private

06b621d

This was referenced Sep 1, 2020

Re-enable java signalr tests in Helix #25510

Closed

Update documentation to reference new Java package #25511

Closed

Java signalr tests can't be debugged in VSCode #25512

Open

wtgodbe merged commit b44c628 into release/5.0 Sep 2, 2020

wtgodbe deleted the wtgodbe/MessagePackage branch September 2, 2020 00:37

wtgodbe mentioned this pull request Sep 2, 2020

Separate Java's MessagePackHubProtocol into its own package #25087

Closed

BrennanConroy mentioned this pull request Sep 3, 2026

[SignalR] [Java] Fix hang when reading an HTTP response body fails #69037

Merged

Conversation

wtgodbe commented Aug 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BrennanConroy commented Aug 26, 2020

Uh oh!

wtgodbe commented Aug 26, 2020

Uh oh!

wtgodbe commented Aug 26, 2020

Uh oh!

BrennanConroy commented Aug 26, 2020

Uh oh!

wtgodbe commented Aug 31, 2020

Uh oh!

wtgodbe commented Aug 31, 2020

Uh oh!

ghost commented Aug 31, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebastienros commented Aug 31, 2020

Uh oh!

BrennanConroy left a comment

Choose a reason for hiding this comment

Uh oh!

Pilchie commented Sep 1, 2020

Uh oh!

Uh oh!

halter73 Sep 1, 2020

Choose a reason for hiding this comment

Uh oh!

wtgodbe Sep 1, 2020

Choose a reason for hiding this comment

Uh oh!

halter73 Sep 1, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghost commented Sep 1, 2020

Uh oh!

Pilchie commented Sep 1, 2020

Uh oh!

jamshedd commented Sep 1, 2020

Uh oh!

jamshedd commented Sep 1, 2020

Uh oh!

Uh oh!

wtgodbe commented Sep 1, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wtgodbe commented Aug 25, 2020 •

edited

Loading