Skip to content

Suspicious comment about non-existing lock in System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning() #92

Closed

Description

@Dmitry-Me

System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning() has this warning:

  // call OnError outside of _ErrorCollectionLock to avoid deadlock

there's nothing called _ErrorCollectionLock or similarly in the codebase. The comment is full of magic.

Activity

  1. removed their assignment
    on Mar 24, 2017
  2. transferred this issue fromdotnet/corefxon May 16, 2019
  3. divega commented on May 16, 2019

    @divega

    As recently announced in the .NET Blog, focus on new SqlClient features an improvements is moving to the new Microsoft.Data.SqlClient package. For this reason, we are moving this issue to the new repo at https://github.com/dotnet/SqlClient. We will still use https://github.com/dotnet/corefx to track issues on other providers like System.Data.Odbc and System.Data.OleDB, and general ADO.NET and .NET data access issues.

  4. added this to the milestone on May 17, 2019
  5. JRahnama commented on Aug 21, 2020

    @JRahnama
    Contributor

    Closing as PR#684 is merged and it will be in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions