Repository navigation
Fix case insensitivity for the managed engine on git worktrees, and implement for libgit2 - #1334
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes case-insensitive version file lookup when a repo-relative path’s casing doesn’t match what Git recorded, with special attention to git worktrees and bringing LibGit2 behavior in line with the managed engine.
Changes:
- Updated the case-insensitive path matching test to require the behavior for both Managed and LibGit2 engines.
- Managed engine:
core.ignorecasedetection now checks bothCommonDirectory/configandGitDirectory/configto better support worktrees. - LibGit2 engine: normalizes the repo-relative project directory path to the commit tree’s actual casing when
core.ignorecaseis enabled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Nerdbank.GitVersioning.Tests/VersionFileTests.cs | Strengthens the case-insensitive path test to apply to both engines. |
| src/NerdBank.GitVersioning/ManagedGit/GitRepository.cs | Improves core.ignorecase config discovery for worktree scenarios by checking common + worktree git dirs. |
| src/NerdBank.GitVersioning/LibGit2/LibGit2VersionFile.cs | Adds tree-based case-insensitive path normalization when core.ignorecase is true. |
…mplement for libgit2
AArnott
force-pushed
the
better-case-insensitivity
branch
from
April 3, 2026 21:53
35118ef to
e6198dc
Compare
AArnott
enabled auto-merge
April 3, 2026 21:54
This was referenced Jun 19, 2026
Closed
This was referenced Sep 1, 2026
Open
This was referenced Sep 10, 2026
Closed
This was referenced Sep 20, 2026
This was referenced Oct 8, 2026
This was referenced Oct 19, 2026
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.