Repository navigation
Revert "chore: Skip setting process priority when running on non windows environment" - #2949
Conversation
This reverts commit ab8de31.
|
@adamsitnik Is it acceptable to add logics to skip setting process priority when running on running GitHub Actions Hosted runner Additional code to // GitHub Actions environment variables https://docs.github.com/en/actions/reference/workflows-and-actions/variables#default-environment-variables
public static readonly bool IsRunningOnGitHubActions = Environment.GetEnvironmentVariable("GITHUB_ACTIONS") == "true";
public static readonly bool IsRunningOnGitHubHostedRunner = IsRunningOnGitHubActions
&& Environment.GetEnvironmentVariable("RUNNER_ENVIRONMENT") == "github-hosted"; |
No problem. I have developed this skill after years of working on the .NET Team and being constantly warned about very subtle breaking changes.
I would prefer us to modify the code that creates configs for tests and disable it there in explicit way. Because our users could in theory run as sudo using GH actions. |
Reverts #2924 for reasons described here: #2924 (review)