Repository navigation
(feat) Worker: run every job in its own defer() scope - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
defer()available in the framework, jobs have no execution scope of their own. A queue worker is a long-lived process, so a callback registered by one job must not survive into the next, and cleanup has to run before the worker records the job's outcome.Solution
QueueWorker::executeJob()runs$job->handle()throughapp()->runInDeferScope():Behavior
executeJob()is the shared point and the callbacks run in the process that ran the job.dispatchSync()/queueAsSync()/Drainexecute inside the caller's execution, so theirdefer()callbacks belong to the caller's scope. This is unchanged.Compatibility
The call is guarded with
method_exists($app, 'runInDeferScope'), so theworker behaves exactly as before on framework versions that do not have
defer(). No new requirement is added tocomposer.json.Tests
Two tests in
QueueWorkerTest, using a container that implements the scopeAPI:
run-a, cleanup-a, run-b, cleanup-b)