[rykov]

All modern browsers use ES5 as their standard, and it often causes confusion when Javascript files fail to compress, but work in the browser. I often run into this roadblock when using the Rails Asset Pipeline in development mode (no compression) vs precompiling (with compression).

This change makes ES5 the default compression.

[doxavore]

👍 This would be a nice thing to merge.

[rykov]

I just got bit by this again as well. Please merge or advise

[jashkenas]

Will do -- but before I do ... what exactly is the change that this makes? Also, if you rebase it, I can merge cleanly.

[caseywebdev]

Stuff like

var arr = [1, 2,];
var obj = {a: 1, b: 2,};

will not compile without setting language/language_in to ECMASCRIPT5. This is annoying for third party scripts that have trailing commas. Other nuances too probably...

[rykov]

My issue is hard errors on terms that were reserved in EMCA 3 (the current default), but released in EMCA 5. Ember.js uses volatile as a function name, which works fine in all browsers but causes errors in closure-compiler

[jashkenas]

Mind rebasing so I can merge cleanly?

[rykov]

Putting it together now

On Tue, Dec 11, 2012 at 10:20 AM, Jeremy Ashkenas
notifications@github.comwrote:

Mind rebasing so I can merge cleanly?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/21#issuecomment-11255462.

[rykov]

Ok - it's ready.