Repository navigation
Is PROFILE_TASK actually used in the Dockerfile? #979
Description
I see that in the history of the linux template, that PROFILE_TASK was specifically set to a value and used across both invocation of make. However, I downloaded the 3.12.7 and 3.13.0 Dockerfiles to understand what it going on, and I enabled Docker's full logging and noticed that the profiling step does not get invoked.
It appears that this variable is now "" and then the Makefile just skips the step, thus essentially disabling the --enabled-optimization flag.
If someone could just confirm my findings and ensure I am not missing something, that would be awesome.
Thanks!
Activity
yosifkit commentedon Oct 15, 2024
Doh, yeah that is causing it to skip the optimizations 😢. Now that none of the python versions need
PROFILE_TASK, we can just drop it out of the template and apply the results (rather than having to conditionalize it in the template). Looks like it was missed whenPROFILE_TASKwas moved around in #794.edmorley commentedon Oct 15, 2024
Wouldn't the
test -zhere ignorePROFILE_TASKif set to the empty string, and so continue to use the default task in that case?https://github.com/python/cpython/blob/37e533a39716bf7da026eda2b35073ef2eb3d1fb/configure.ac#L1905
edmorley commentedon Oct 15, 2024
(but either way, passing in
PROFILE_TASKis dead code now and can be removed :-) )yosifkit commentedon Oct 15, 2024
Yeah, but we're setting for the
makeinvocation, which doesn't look for emptypython/3.13/bookworm/Dockerfile
Lines 53 to 56 in 7666104
https://github.com/python/cpython/blob/37e533a39716bf7da026eda2b35073ef2eb3d1fb/Makefile.pre.in#L330
RobertDeRose commentedon Oct 15, 2024
Oh, glad I am not crazy, I can open a PR for this.
yosifkit commentedon Oct 15, 2024
That'd be great. Thank you!
Do not set PROFILE_TASK environment variable
Do not set PROFILE_TASK environment variable
Do not set PROFILE_TASK environment variable