Skip to content

docs: explain local nolint style suppression - #981

Open
dajiaohuang wants to merge 2 commits into
dlang-community:masterfrom
dajiaohuang:docs/nolint-style-check-20261016
Open

dajiaohuang wants to merge 2 commits into
dlang-community:masterfrom
dajiaohuang:docs/nolint-style-check-20261016

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Oct 16, 2026 •

Copy link
Copy Markdown

Document declaration-level nolint with a verified redundant-initializer example, its scope, and the difference from editor-only ignore settings and stable v0.15.2.

Actual execution against master 457fab85a73763f2dfc392395299107faed260cd showed that the original C-binding example in this PR still emits the naming warning, even on a build containing #936. The naming checker overrides declaration visitation without the suppression handling in BaseAnalyzer. This revision removes the ineffective example, uses a working check, and explicitly documents that upgrading alone does not suppress CRYPTO_memcmp. This is a documentation correction, not a fix to the naming checker; that part of #979 remains a limitation.

Validation (WSL Ubuntu 24.04, official portable DMD 2.111.0, pinned Git submodules):

  • make -j2 all: passed.
  • make -j2 test: passed, 54 modules.
  • Compiled the original C declaration and the revised initializer example with dmd -c.
  • CLI -S/lint and JSON --report reproduced the original naming warning with and without its UDA. The replacement initializer example suppresses count while reporting the nearby unsuppressed initializer.
  • README hello-world syntax/import/token/sloc CLI smoke checks passed (token output is 28 for this compiler/parser build).
  • Existing tests/it.sh passed after normalizing the Windows checkout's script and text fixture line endings to LF locally. Initial CRLF execution/expected-output failures were environment-specific; no fixture or test-source changes are included in this PR.
  • git diff --check: passed. No compiler/OS matrix, DUB build, external source scan, or Phobos scan was run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant