Repository navigation
docs: explain local nolint style suppression - #981
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document declaration-level
nolintwith a verified redundant-initializer example, its scope, and the difference from editor-only ignore settings and stable v0.15.2.Actual execution against master
457fab85a73763f2dfc392395299107faed260cdshowed that the original C-binding example in this PR still emits the naming warning, even on a build containing #936. The naming checker overrides declaration visitation without the suppression handling inBaseAnalyzer. This revision removes the ineffective example, uses a working check, and explicitly documents that upgrading alone does not suppressCRYPTO_memcmp. This is a documentation correction, not a fix to the naming checker; that part of #979 remains a limitation.Validation (WSL Ubuntu 24.04, official portable DMD 2.111.0, pinned Git submodules):
make -j2 all: passed.make -j2 test: passed, 54 modules.dmd -c.-S/lintand JSON--reportreproduced the original naming warning with and without its UDA. The replacement initializer example suppressescountwhile reporting the nearby unsuppressed initializer.tests/it.shpassed after normalizing the Windows checkout's script and text fixture line endings to LF locally. Initial CRLF execution/expected-output failures were environment-specific; no fixture or test-source changes are included in this PR.git diff --check: passed. No compiler/OS matrix, DUB build, external source scan, or Phobos scan was run.