Repository navigation
Handle Medium request failures - #66
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the
requestcallback reports a transport error,resis absent. The existing callback dereferencedres.statusCode, causing an uncaught TypeError and leaving thegetStoriespromise unresolved. Other non-200/non-404 responses also left the promise pending.Change
Propagate request and HTTP errors through the existing callback/promise path, so callers receive a rejected promise instead of a crash or hang. Successful response processing is unchanged.
Validation
node --check lib/post.jsgit diff --checkrequestcallbacks for synthetic network error, HTTP 503, and HTTP 404 each produced a rejected promise with the expected error.