Repository navigation
Simple example of running pbench agent in a container - #3259
Conversation
webbnh
left a comment
There was a problem hiding this comment.
I don't know that you were expecting any review, but I think this is good.
I just noted a few things that I ran into using this, today.
|
Thanks for the review! PRs to address these and other changes folks would want are welcome! |
webbnh
left a comment
There was a problem hiding this comment.
If generate-token will write to a file, will results-move read from it?
webbnh
left a comment
There was a problem hiding this comment.
This looks great (although, I did find one typo, and I have a couple of suggestions).
Perhaps independent of this PR, we should seriously consider setting up the Agent containers with entrypoints which point to a wrapper script which executes /opt/pbench-agent/profile before executing the requested command, so that that environment is always in place for commands run inside the container (and so that we don't have to do it in every script).
We want to make it as easy for the user to do this as possible. The new `README.md` describes the steps, which are just running `./setup.sh` and executing `example-driver.sh`.
|
I cleaned up all |
Note that this PR assumes the Pbench Agent used includes the work from PR #3264.