Skip to content

Simple example of running pbench agent in a container - #3259

Merged
portante merged 2 commits into
distributed-system-analysis:mainfrom
portante:example
Mar 6, 2023
Merged

portante merged 2 commits into
distributed-system-analysis:mainfrom
portante:example

Conversation

@portante

@portante portante commented Feb 16, 2023 •

Copy link
Copy Markdown
Member
We want to make it as easy for the user to do this as possible.  The new
`README.md` describes the steps, which are just running `./setup.sh` and
executing `example-driver.sh`.

Note that this PR assumes the Pbench Agent used includes the work from PR #3264.

webbnh
webbnh previously approved these changes Feb 16, 2023

@webbnh webbnh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that you were expecting any review, but I think this is good.

I just noted a few things that I ran into using this, today.

Comment thread contrib/containerized-pbench/README Resolved
Comment thread contrib/containerized-pbench/README Resolved
Comment thread contrib/containerized-pbench/README Resolved
@portante portante added this to the v0.72 milestone Feb 16, 2023
@portante

Copy link
Copy Markdown
Member Author

Thanks for the review!

PRs to address these and other changes folks would want are welcome!

@portante portante left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted back to Draft mode until PR #3264 lands to provide generation of a pbench token to a file.

webbnh
webbnh previously approved these changes Feb 20, 2023

@webbnh webbnh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If generate-token will write to a file, will results-move read from it?

@portante
portante marked this pull request as ready for review February 23, 2023 18:52
@portante
portante requested a review from webbnh February 23, 2023 18:52
webbnh
webbnh previously approved these changes Feb 23, 2023

@webbnh webbnh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great (although, I did find one typo, and I have a couple of suggestions).

Perhaps independent of this PR, we should seriously consider setting up the Agent containers with entrypoints which point to a wrapper script which executes /opt/pbench-agent/profile before executing the requested command, so that that environment is always in place for commands run inside the container (and so that we don't have to do it in every script).

Comment thread contrib/containerized-pbench/README.md Resolved
Comment thread contrib/containerized-pbench/setup.sh Resolved
Comment thread contrib/containerized-pbench/setup.sh Resolved
@ndokos
ndokos self-requested a review February 27, 2023 14:49
ndokos
ndokos previously approved these changes Feb 27, 2023
dbutenhof
dbutenhof previously approved these changes Mar 3, 2023
portante added 2 commits March 4, 2023 13:25
We want to make it as easy for the user to do this as possible.  The new
`README.md` describes the steps, which are just running `./setup.sh` and
executing `example-driver.sh`.
@portante
portante dismissed stale reviews from dbutenhof and ndokos via 8f92651 March 4, 2023 18:27
@portante

portante commented Mar 6, 2023

Copy link
Copy Markdown
Member Author

I cleaned up all *@tmp/* files in the Jenkins executors across all workspaces, and then restarted this build to see if it will pass.

@webbnh webbnh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@portante
portante merged commit a968551 into distributed-system-analysis:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants