Skip to content

Use the APIAbort exception to defer the abort to _dispatch for consistency #3137

Open

Description

@portante

We should really use the APIAbort exception to defer the abort to _dispatch so we're consistent. We still have the user API classes that don't extend ApiBase, unfortunately, but they'll be gone soon. (I fixed PUT, and I'll retain that part of the PR along with the error-case functional tests when I can rebase on top of your NGINX fix.)

So I'll approve this without a lot of excitement; but it is an immediate fix for the namespace mismatch, and we still have the user APIs... and the message example is probably a nice touch.

Originally posted by @dbutenhof in #3130 (review)

Activity

  1. changed the title [-]We should really use the `APIAbort` exception to defer the `abort` to `_dispatch` so we're consistent. We still have the user API classes that don't extend `ApiBase`, unfortunately, but they'll be gone soon. (I fixed `PUT`, and I'll retain that part of the PR along with the error-case functional tests when I can rebase on top of your NGINX fix.)[/-] [+]Use the `APIAbort` exception to defer the `abort` to `_dispatch` for consistency[/+] on Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions