Repository navigation
A browser binary path's file name is read per its own path form - #1449
Merged
Merged
Conversation
The browser-provider executable gate took a candidate's file name as the last segment after splitting on both `/` and `\`. On macOS and Linux a backslash is an ordinary file-name character, so `/r/x\agent-browser` (a file literally named `x\agent-browser`) passed the provider-filename check. Rule chosen: a POSIX-absolute path (leading `/`) splits on `/` only, and a drive path (`C:\` or `C:/`) keeps splitting on both. That is how each platform itself reads the path, so the file name and the `..` check now see the same segments the OS does: a `\..\` inside a POSIX path is part of a file name, not a parent step. No platform check, since the same gate runs in the webview, `dor`, and both hosts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
17e19a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://47c347d4.mouseterm.pages.dev |
| Branch Preview URL: | https://audit-s168-posix-filename.mouseterm.pages.dev |
dormouse-bot
approved these changes
Oct 30, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dormouse-bot
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser-provider executable gate (
isAllowedBrowserBinaryindor-lib-common/src/browser-providers.ts) took a candidate's file name as the last segment after splitting on both/and\. On macOS and Linux a backslash is an ordinary file-name character, so a path like/r/x\agent-browser, whose file is literally namedx\agent-browser, read asagent-browserand passed the provider-filename check.Now each path form splits on its own separators:
/) splits on/only, so its file name is what follows the last/;C:\orC:/) keeps splitting on both.The
..check sees the same segments, so a\..\inside a POSIX path is part of a file name, as the OS reads it. There is no platform check, because the same gate runs in the webview,dor, and both hosts.Tests in
lib/src/lib/agent-browser-binary.test.ts:/r/x\agent-browserand/r/x\playwright-cliare refused, a drive path with..between backslashes is refused, and a drive path that mixes separators is still accepted. Both refusing cases fail with the old split restored.🤖 Generated with Claude Code