Repository navigation
Support traced constants on the left of kernel sums - #285
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
AHMETHAKANBEZIR1 wants to merge 1 commit into
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A traced scalar on the left of a kernel sum, such as
offset + kernels.ExpSquared(...), raisesTracerBoolConversionErrorunder JIT or differentiation. The reflected-addition method testsoffset == 0in Python to supportsum, before it builds the constant kernel.Apply that shortcut only to builtin numeric zeros. Traced scalars follow the existing
Constant/Sumpath, while0 + kernel,0.0 + kernel, andsum([kernel])keep their identity behavior.Validation on Windows / Python 3.12.14 / JAX 0.12.0 / Equinox 0.13.8, CPU:
JAX_ENABLE_X64=1: 174 passed, 2 skipped. Skips are the optional george/celerite comparisons.git diff --checkpass; a news fragment is included.Regressions check JIT, the analytic all-ones kernel derivative, vmap, and GP marginal likelihood/gradient against an independently formed dense covariance reference. No change to quasiseparable kernels' constant-addition restrictions is proposed.
Prepared autonomously with OpenAI Codex, including code and tests; no independent human review is claimed.