Skip to content

refactor(workspace): rename pro leftovers to platform - #1696

Merged
skevetter merged 1 commit into
mainfrom
refactor/platform-rename-pro-leftovers
Oct 25, 2026
Merged

skevetter merged 1 commit into
mainfrom
refactor/platform-rename-pro-leftovers

Conversation

@skevetter

@skevetter skevetter commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Rename listProWorkspacesForProvider to listPlatformWorkspacesForProvider; its args move into a listPlatformWorkspacesForProviderParams struct (same shape as listPlatformInstancesParams).
  • Rename pro.example, pro.example.com, and the pro-login lock name to platform.* in cmd/pro and cmd/env_flags_test.go fixtures.
  • Skipped providers/providers.go (ProProvider) and pkg/config/pathmanager_linux_test.go: both are in open PRs (feat(provider): add Colima runtime support #757, feat(dependencies): build provider dependency foundations #1588) per the rename skip rule.

Why

listProWorkspacesForProvider is an internal helper still named after the Pro product. The fixture hosts are arbitrary strings compared only with values produced inside the same test, so renaming them changes no behaviour. The params struct keeps the call at two arguments.

Validation

  • go build ./...
  • GOOS=windows go vet ./pkg/workspace/... ./cmd/pro/...
  • mise run cli:format
  • mise run cli:lint:ci: 0 issues
  • go test ./pkg/workspace/... ./cmd/pro/... ./cmd/: pass
  • Pro token regex, before to after: cmd/env_flags_test.go 3 to 2, cmd/pro/login_test.go 8 to 3, cmd/pro/start_test.go 6 to 1, pkg/workspace/list.go 2 to 0.

CodeRabbit CLI

Failed twice: rate limit (free OSS reviews exhausted; latest retry reported about 12 minutes until reset). Continuing; the GitHub CodeRabbit review still gates.

Tier

T1: internal identifiers and test fixtures.

Auto-merge

Eligible: yes. Non-test changed lines: 44 (pkg/workspace/list.go), 1 non-test file. Test changes: 22 lines.

Remaining

Next

Summary by CodeRabbit

  • Refactor
    • Updated internal workspace-listing organization. Workspace results and error handling remain unchanged.
  • Tests
    • Updated environment and login test expectations to use the platform.example host. No user-facing behavior changes are included.

@skevetter skevetter added the rename Loft/Pro rename label Oct 25, 2026
@netlify

netlify Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit ffa6a99
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6adda9938678760ac5339d64

@netlify

netlify Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit ffa6a99
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6adda993b407227298f98e67

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f8fb7ca0-b2ee-4f4d-877a-4d394941e56a
Commits

Reviewing files that changed from the base of the PR and between 825dd3d and ffa6a99.

Files selected for processing: 4
  • cmd/env_flags_test.go
  • cmd/pro/login_test.go
  • cmd/pro/start_test.go
  • pkg/workspace/list.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The workspace provider-listing helper is renamed and now accepts its inputs through a parameter struct. Related command tests replace Pro host and lock values with Platform values.

Changes: Platform naming update

Layer / File(s) Summary
Rename workspace listing helper
pkg/workspace/list.go
The helper is renamed to listPlatformWorkspacesForProvider and now receives its inputs through a parameter struct.
Update Platform host test values
cmd/env_flags_test.go, cmd/pro/login_test.go, cmd/pro/start_test.go
The tests use Platform host and lock values in place of Pro values.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Possibly related issues

  • Issue 1551 tracks the Pro-to-Platform rename and lists listProWorkspacesForProvider as a remaining rename; this change renames that helper.
Merge Risk: Minimal · up to ffa6a

The naming update appears ready to merge after normal checks.

Pre-merge checks: Passed 3 · Failed 2

Failed Failed checks: 2 warnings

Check name Status Explanation Resolution
Description check Warning The description explains the main changes, rationale, scope exclusions, and validation results. However, it omits required template information, including the change type, issue reference or explicit … Add the required template sections or equivalent information. Specify the change type, provide "Fixes #N", "Refs #N", or "none", disclose AI assistance and complete its fields, confirm the applicable testing and checklist items, and describ…
Docstring Coverage Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main refactor: renaming remaining Pro identifiers to Platform.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the main changes, rationale, scope exclusions, and validation results. However, it omits required template information, including the change type, issue reference or explicit "none", AI-assistance disclosure, checklist confirmations, and manual verification details.

Resolution

Add the required template sections or equivalent information. Specify the change type, provide "Fixes #N", "Refs #N", or "none", disclose AI assistance and complete its fields, confirm the applicable testing and checklist items, and describe manual verification commands and observed results.

Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@skevetter
skevetter marked this pull request as ready for review October 25, 2026 08:35
@mergify

mergify Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter
skevetter merged commit c7b5de6 into main Oct 25, 2026
114 checks passed
@skevetter
skevetter deleted the refactor/platform-rename-pro-leftovers branch October 25, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rename Loft/Pro rename size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant